Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#102-Navbar-and-Coindesk-logo #103

Conversation

therealharshit
Copy link
Member

Description

This pr decreases the height of navbar and crop the coindesk logo to remove vertical line.

Fixes #102

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MAVRICK-1
Copy link
Member

@therealharshit can u add picture of your fixes in the PR

@MAVRICK-1 MAVRICK-1 self-requested a review January 17, 2025 19:41
@yashksaini-coder
Copy link
Member

@therealharshit can u add picture of your fixes in the PR

I thought only I was coding this late

@therealharshit
Copy link
Member Author

@therealharshit can u add picture of your fixes in the PR

@MAVRICK-1 sure, here are those

navbar normally:
nav normal

navbar sticky and coindesk logo:
nav sticky and coindesk logo

@MAVRICK-1 MAVRICK-1 merged commit 0734930 into DEVRhylme-Foundation:dev Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar and Coindesk logo
3 participants