RTL Support #208

vbuberen · 2020-01-25T21:06:24Z

📷 Screenshots

Before	After

📄 Context

PR addresses feature request #117
Since Chucker currently has min API 16 as supported, while RTL properties are available from 17, I added all RTL related things into styles in values-v21, which means that RTL works only from Android 5.0 (API 21) and newer.

📝 Changes

Closes Better RTL support #117
Added tags to define text direction and alignment in styles.xml
Replaced TableLayout with ConstrainLayout in TransactionOverviewFragment layout.
Added useVectorDrawables = true in build.gradle to avoid PNG generation during builds and use real vectors.
Replaced android:src with app:srcCompat to use vector drawable via AndroidX library.
Fixed constraints to close Text constraints issue in transactions list #241

📝 How to test

Set Force RTL in Developer options or switch to some RTL locale.

🔮 Next steps

Would like to hear some feedback from real RTL users, who could tell if I did everything right. Since I am not an RTL user, can't claim that it works as it should.

vbuberen · 2020-02-14T22:41:40Z

This PR now closes #241 as well.

vbuberen · 2020-02-22T16:39:05Z

Let's check and merge it. It seems we won't get feedback from the original reporter of this feature request.
Also, the PR has some additional fixes, like fix #241

Finally, due to #227 I updated ids for layouts items to be 100% sure we are not clashing with ids in users projects.

cortinico

Done some manual testing and it works great! I'm not a RTL expert so I can't really say if it works naturally but overall looks good.

cortinico · 2020-02-24T23:38:16Z

library/src/main/AndroidManifest.xml

@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.chuckerteam.chucker">
-    <application>
+    <application
+      android:supportsRtl="true">


This should be avoided. Ideally we should not set a android:supportsRtl in the library as this gets merged in the final manifest. The default value for supportsRtl is false.

Moreover we might break builds for users that have supportsRtl set to false on the host app. See also #121 (comment)

cortinico · 2020-02-24T23:48:47Z

library/src/main/res/values-v21/styles.xml

-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools">
+
+   <style name="Chucker.Theme" parent="Theme.MaterialComponents.DayNight.NoActionBar">


Can I ask you to refactor to have a:

<style name="Chucker.BaseTheme" parent="Theme.MaterialComponents.DayNight.NoActionBar">

inside the res/values/styles.xml with all the common theme attributes?

We can then have the Chucker.Theme defined in both values and values-v21 so we don't need to copy over the theme twice.

Sure. I just thought that we might bump minSDK to 21 pretty soon due to Retrofit updates, etc.

Yeah true, but we don't have a PR pending for that (plus would be a major version bump). I think it's better if we keep the theme clean. Moreover having this setup with a BaseTheme could be handy for future similar scenarios

cortinico · 2020-02-24T23:49:44Z

library/src/main/res/values-v21/styles.xml

+    <style name="Chucker.TextAppearance.TransactionTitle" parent="TextAppearance.AppCompat.Widget.ActionBar.Title">
+        <item name="android:gravity">top</item>
+        <item name="android:textSize" tools:ignore="SpUsage">16dp</item>
+        <item name="android:maxLines">2</item>
+    </style>


Why is this needed?

Just left it from original styles. It is used in TransactionActivity and ErrorActivity for toolbar title. Actually, I am against using dps for text sizes here. Will update as well.

vbuberen · 2020-02-25T10:31:19Z

gradle.properties

@@ -16,6 +16,8 @@ org.gradle.jvmargs=-Xmx1536m
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 org.gradle.parallel=true

+android.useAndroidX=true


Added, because 3.6.0 plugin throws error without it.

vbuberen · 2020-02-25T15:59:38Z

@cortinico It is updated and ready for a new round of review.

cortinico

LGTM 👍

cortinico · 2020-02-25T17:03:25Z

library/src/main/AndroidManifest.xml

+
        <activity android:name="com.chuckerteam.chucker.internal.ui.transaction.TransactionActivity"
            android:theme="@style/Chucker.Theme"
            android:parentActivityName="com.chuckerteam.chucker.internal.ui.MainActivity"/>
+


nit: whitespace change here that can be reverted

I`ve added it for readability.

vbuberen · 2020-02-25T18:06:37Z

Just tested it myself and saw that there is an issue due to supportVectorDrawables = true - Chucker crashes on devices with API 16-19. Will fix it later today. Do not merge, please.

… due to notifications icons

vbuberen · 2020-02-25T21:22:47Z

Issues is fixed. In case someone interested in reasons here is the link to the comment in the issue similar to what was seen:
https://stackoverflow.com/a/38999661/7339798

* Remove scroll flags (#210) * Fix/gradle properties (#211) * Allow Gradle parallel build * Fix version name * Fix for curl command (#214) * Fix R8 minification crash on TransactionViewModel creation. (#219) * Big resources renaming (#216) * Fix clear action crash when application is dead (#222) * Fix for crash on Save transaction action (#221) * Show warning is transaction is null, fix crash in Save action * Uncomment sample transactions * Replace mulptiple returning with multiple throw due to detekt issue * Add message into IOException, update string for request being not ready * Fix for NPE in NotificationHelper (#223) * Add additional check fo transaction being not null before getting its notificationText * Extract transaction item from transactionBuffer * ViewModel refactoring (#220) * Update ViewModel dependency, refactor TransactionViewModel * Dependencies clean up * Switch to ViewModel on the main screen * Fix depleting bytes from the response. (#226) * Use HttpUrl instead of Uri for parsing URL data. * Do not read image sources directly from the response. * Simplify gzip logic. * Move gzip checks from IoUtils to OkHttpUtils. * Remove unused 'Response.hasBody()' extension. * Update library/src/main/java/com/chuckerteam/chucker/internal/support/OkHttpUtils.kt * Revert resource renaming (#227) * Revert renaming * Add changelgos for 3.1.2 (#230) * Add missing section to release 3.1.1 and 3.1.2 (#232) * Update Github templates (#235) * Update templates * Remove redundant dot * Remove default `no` from the checkbox * Switch to platform defined HTTP code constants (#238) * Add instruction for checkbox selection (#237) * Fix HttpHeader serialization when obfuscation is enabled (#240) * Update README (#243) * Add Action to validate the Gradle Wrapper (#245) * Gradle to 6.2 (#247) * Do not refresh transaction when it is not being affected. (#246) * Do not refresh transaction when it is not being affected. * Use correct null-aware comparison for HttpTransaction. * Add switching between encoded and decoded URL formats. (#233) * Add switching between encoded and decoded URL formats. * Make URL encoding transaction specific. * Change test name for upcoming #244 PR. * Use LiveDataRecord for combineLatest tests. * Properly switch encoding and decoding URL. * Show encoding icon only when it is viable. * Add encoded URL samples to HttpBinClient. * Avoid using 'this' scoping mechanism for URL. * Fix typo in feature request comment (#251) * RTL Support (#208) * Remove ltr forcing and replace ScrollView in Overview * Replace Overview layout, add rtl support for it * Add textDirection and textAlignment property for API 21+ * Fix host textview constraints * Replace android:src with app:srcCompat * Update ids for layouts to avoid clashes * Update Material components to stable * Remove supportsRTL tag from Manifest, update Gradle plugin * Styles update * Remove supportsRTL from library manifest * Revert usage of supportVectorDrawables to avoid crashes on APIs 16-19 due to notifications icons * Fix lint issue with vector drawable * Response search fixes (#256) * Fix response search to be case insensitive * Add minimum required symbols * Fix invalid options menu in response fragment * Feature/tls info (#252) * Add UI for TLS info * Implement logic for retrieving TLS info * Address code review feedback * Switch views to ViewBinding (#253) * Switch to ViewBinding in activities * Switch to ViewBinding in ErrorsAdapter, add formattedDate field into Throwable models * Transaction adapter switch to ViewBinding * Remove variable for formatted date from models * Switch to ViewBinding in TransactionPayloadAdapter * Switch to ViewBinding in TransactionPaayload and TransactionOverviewFragments * Switch list fragments to ViewBinding * Fix link for tutorial opening * Rename views * Address code review feedback * Hide SSL field if isSSL is null * Libs update (#260) * Update tools versions * JUnit update * Feature/truth (#258) * Add Truth, update part of test classes * Convert other tests to use Truth, fix date parser test * Add Truth assertions to FormatUtilsTest, fix ktlint issue * Update assertions to a proper syntax * Add missing ThrowableViewModel (#257) * Add Error ViewModel, update title in TransactionActivity in onCreate * Switch from errors to throwable naming to have a uniform naming style * Rename toolbar title * Migrating from Travis to GH Actions (#262) * Setup GH Actions * Run only on Linux * Remove Travis File * Run only gradlew directly * Update targetSDK and Kotlin (#264) * Add stale builds canceller (#265) * Add filters * Update Gradle wrapper validation workflow * Update pre-merge workflow * Fixed various Lints (#268) * fixed typos * fixed KDocs * Replace Travis badge with GH Actions badge (#269) * Remove redundant JvmName (#274) * Fix margins and paddings for payload items (#277) * Add selective interception. (#279) * Add selective interception. * Update README.md. * Align formatting in README with other points. * Avoid header name duplication. * Strip interception header also in the no-op library. * UX improvements (#275) * Add icon for non-https transactions * Update secondary color to be more contrast * Simplify protocol resources setting * Add tests to format utils (#281) * add tests to format utils * fixes after code review * formatting fix Co-authored-by: adammasyk <adam.masyk@programisci.eu> * format utils test refactor (#285) * format utils test refactor * share text test refactor * Migrate to Kotlin Coroutines (#270) * Add coroutine as a dependency in build.gradle * Migrate AsyncTasks to kotlin coroutines * Migrate executors with the coroutines in repositories * Multi cast upstream response for Chucker consumption. (#267) * Multi cast response upstream for Chucker consumption. * Read buffer prefix before potentially gunzipping it. * Inform Chucker about unprocessed responses. * Simplify multi casting logic. * Move read offset to a variable. * Inline one-line method. * Give better control over TeeSource read results. * Add documentation to TeeSource. * Close side channel when capacity is exceeded. Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com> * Remove unnecessary mock method. (#289) * removed redundant Gson configurations (#290) * increased test coverage for format utils (#291) Co-authored-by: Karthik R <karthr@paypal.com> * added few test cases for json formatting (#295) * Properly handle unexhausted network responses (#288) * Handle properly not consumed upstream body. * Handle IO issues while reading from file. * Update dependencies (#296) * Update depencies * Update OkHttp to 3.12.10 * Handle empty and missing response bodies. (#250) * Add failing test cases. * Remove unused const. * Gzip response body if it was gunzipped. * Add test cases for regular bodies in Chucker. * Fix rule formatting. * Use proper name for application interceptor. * Return original response downstream. * Account for no content with gzip encoding. * Use Truth for Chucker tests. * Honor empty plaintext bodies. * Revert changes to HttpBinClient. * Update library/src/test/java/com/chuckerteam/chucker/ChuckerInterceptorDelegate.kt * Update library/src/main/java/com/chuckerteam/chucker/internal/support/OkHttpUtils.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com> * Add hasFixed size to RecyclerViews (#297) * Detekt to 1.7.4 (#299) * Revert "Add selective interception. (#279)" (#300) This reverts commit d14ed64. * Prepare 3.2.0 (#298) * Update versions info * Update Changelog * Fix links and update date Co-authored-by: Michał Sikora <michalsikora90@gmail.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Sergey Chelombitko <119192+technoir42@users.noreply.github.com> Co-authored-by: Michał Sikora <me@mehow.io> Co-authored-by: Hitanshu Dhawan <hitanshudhawan1996@gmail.com> Co-authored-by: adammasyk <masiol91@gmail.com> Co-authored-by: adammasyk <adam.masyk@programisci.eu> Co-authored-by: Nikhil Chaudhari <nikhyl777@gmail.com> Co-authored-by: karthik rk <karthik.rk18@gmail.com> Co-authored-by: Karthik R <karthr@paypal.com>

vbuberen added 3 commits January 25, 2020 21:30

Remove ltr forcing and replace ScrollView in Overview

05112dc

Replace Overview layout, add rtl support for it

4097a75

Add textDirection and textAlignment property for API 21+

45ece86

vbuberen added this to the 3.2.0 milestone Jan 25, 2020

cortinico added the enhancement New feature or improvement to the library label Jan 26, 2020

Merge latest develop changes

db6b515

vbuberen mentioned this pull request Feb 14, 2020

Text constraints issue in transactions list #241

Closed

vbuberen added 2 commits February 15, 2020 00:34

Merge latest develop changes

02e9573

Fix host textview constraints

3bca5b4

vbuberen added 3 commits February 15, 2020 00:52

Replace android:src with app:srcCompat

2f2194c

Update ids for layouts to avoid clashes

6865b38

Merge branch 'develop' into feature/rtl_support

bbbf3ab

vbuberen requested a review from cortinico February 22, 2020 16:36

vbuberen marked this pull request as ready for review February 22, 2020 16:36

Update Material components to stable

4491d4d

cortinico requested changes Feb 24, 2020

View reviewed changes

vbuberen added 3 commits February 25, 2020 10:57

Remove supportsRTL tag from Manifest, update Gradle plugin

81b8c1d

Styles update

fce27da

Remove supportsRTL from library manifest

5132ba1

vbuberen commented Feb 25, 2020

View reviewed changes

cortinico approved these changes Feb 25, 2020

View reviewed changes

cortinico added the ⛔️ do not merge A PR that should not be merged label Feb 25, 2020

Revert usage of supportVectorDrawables to avoid crashes on APIs 16-19…

ce4b604

… due to notifications icons

vbuberen removed the ⛔️ do not merge A PR that should not be merged label Feb 25, 2020

Fix lint issue with vector drawable

b601b44

vbuberen merged commit ad65dd5 into develop Feb 25, 2020

vbuberen deleted the feature/rtl_support branch February 25, 2020 21:37

vbuberen mentioned this pull request Feb 25, 2020

Better RTL support #117

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RTL Support #208

RTL Support #208

vbuberen commented Jan 25, 2020 •

edited

Loading

vbuberen commented Feb 14, 2020

vbuberen commented Feb 22, 2020 •

edited

Loading

cortinico left a comment

cortinico Feb 24, 2020

cortinico Feb 24, 2020

vbuberen Feb 25, 2020

cortinico Feb 25, 2020

cortinico Feb 24, 2020

vbuberen Feb 25, 2020

vbuberen Feb 25, 2020

vbuberen commented Feb 25, 2020

cortinico left a comment

cortinico Feb 25, 2020

vbuberen Feb 25, 2020

vbuberen commented Feb 25, 2020 •

edited

Loading

vbuberen commented Feb 25, 2020 •

edited

Loading

RTL Support #208

RTL Support #208

Conversation

vbuberen commented Jan 25, 2020 • edited Loading

📷 Screenshots

📄 Context

📝 Changes

📝 How to test

🔮 Next steps

vbuberen commented Feb 14, 2020

vbuberen commented Feb 22, 2020 • edited Loading

cortinico left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vbuberen commented Feb 25, 2020

cortinico left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vbuberen commented Feb 25, 2020 • edited Loading

vbuberen commented Feb 25, 2020 • edited Loading

vbuberen commented Jan 25, 2020 •

edited

Loading

vbuberen commented Feb 22, 2020 •

edited

Loading

vbuberen commented Feb 25, 2020 •

edited

Loading

vbuberen commented Feb 25, 2020 •

edited

Loading