Avoid redundant builds on GH Actions #265

vbuberen · 2020-03-05T12:11:22Z

📄 Context

When first PR with GH Actions was created I saw that builds happen for every single action, be it push or pull request. So it seems that we are ending up with too much redundant work.
According to this thread Github has no native solution for this issue.
In that thread I also saw a few 3rd party actions and decided to test one of them.

📝 Changes

Added https://github.com/marketplace/actions/gh-actions-stale-run-canceller to test auto cancelling

⏱️ Next steps

If it works, I will add this step into the main workflow as well.

Testing action for builds auto-cancelling

vbuberen · 2020-03-05T12:39:48Z

Can't make it work. Probably, something wrong with the config.

accidentally reviewed

cortinico · 2020-03-05T16:24:51Z

be it push or pull request. So it seems that we are ending up with too much redundant work.

I'm ok having it for pull_request only

vbuberen · 2020-03-05T16:43:40Z

Yeah, good idea about leaving only pull requests. I will update the config and see how it behaves.

vbuberen · 2020-03-05T16:48:16Z

@cortinico Updated to trigger workflows only for pull requests. Now we should be good to go.

cortinico · 2020-03-05T17:24:50Z

.github/workflows/gradle-wrapper-validation.yml

@@ -1,10 +1,13 @@
 name: Validate Gradle Wrapper
-on: [push, pull_request]
+on: pull_request


Actually having also

on: push: branches: - develop - release

Would be useful

The idea is that we do have a run just after the merge on the develop and release branch so we're sure the HEAD is green.

That was my next PR)

Great, so do you want to merge this?

No, I just needed to get to the laptop to update this PR.
Now it is ready

Great, feel free to merge as soon as it's ✅

* Remove scroll flags (#210) * Fix/gradle properties (#211) * Allow Gradle parallel build * Fix version name * Fix for curl command (#214) * Fix R8 minification crash on TransactionViewModel creation. (#219) * Big resources renaming (#216) * Fix clear action crash when application is dead (#222) * Fix for crash on Save transaction action (#221) * Show warning is transaction is null, fix crash in Save action * Uncomment sample transactions * Replace mulptiple returning with multiple throw due to detekt issue * Add message into IOException, update string for request being not ready * Fix for NPE in NotificationHelper (#223) * Add additional check fo transaction being not null before getting its notificationText * Extract transaction item from transactionBuffer * ViewModel refactoring (#220) * Update ViewModel dependency, refactor TransactionViewModel * Dependencies clean up * Switch to ViewModel on the main screen * Fix depleting bytes from the response. (#226) * Use HttpUrl instead of Uri for parsing URL data. * Do not read image sources directly from the response. * Simplify gzip logic. * Move gzip checks from IoUtils to OkHttpUtils. * Remove unused 'Response.hasBody()' extension. * Update library/src/main/java/com/chuckerteam/chucker/internal/support/OkHttpUtils.kt * Revert resource renaming (#227) * Revert renaming * Add changelgos for 3.1.2 (#230) * Add missing section to release 3.1.1 and 3.1.2 (#232) * Update Github templates (#235) * Update templates * Remove redundant dot * Remove default `no` from the checkbox * Switch to platform defined HTTP code constants (#238) * Add instruction for checkbox selection (#237) * Fix HttpHeader serialization when obfuscation is enabled (#240) * Update README (#243) * Add Action to validate the Gradle Wrapper (#245) * Gradle to 6.2 (#247) * Do not refresh transaction when it is not being affected. (#246) * Do not refresh transaction when it is not being affected. * Use correct null-aware comparison for HttpTransaction. * Add switching between encoded and decoded URL formats. (#233) * Add switching between encoded and decoded URL formats. * Make URL encoding transaction specific. * Change test name for upcoming #244 PR. * Use LiveDataRecord for combineLatest tests. * Properly switch encoding and decoding URL. * Show encoding icon only when it is viable. * Add encoded URL samples to HttpBinClient. * Avoid using 'this' scoping mechanism for URL. * Fix typo in feature request comment (#251) * RTL Support (#208) * Remove ltr forcing and replace ScrollView in Overview * Replace Overview layout, add rtl support for it * Add textDirection and textAlignment property for API 21+ * Fix host textview constraints * Replace android:src with app:srcCompat * Update ids for layouts to avoid clashes * Update Material components to stable * Remove supportsRTL tag from Manifest, update Gradle plugin * Styles update * Remove supportsRTL from library manifest * Revert usage of supportVectorDrawables to avoid crashes on APIs 16-19 due to notifications icons * Fix lint issue with vector drawable * Response search fixes (#256) * Fix response search to be case insensitive * Add minimum required symbols * Fix invalid options menu in response fragment * Feature/tls info (#252) * Add UI for TLS info * Implement logic for retrieving TLS info * Address code review feedback * Switch views to ViewBinding (#253) * Switch to ViewBinding in activities * Switch to ViewBinding in ErrorsAdapter, add formattedDate field into Throwable models * Transaction adapter switch to ViewBinding * Remove variable for formatted date from models * Switch to ViewBinding in TransactionPayloadAdapter * Switch to ViewBinding in TransactionPaayload and TransactionOverviewFragments * Switch list fragments to ViewBinding * Fix link for tutorial opening * Rename views * Address code review feedback * Hide SSL field if isSSL is null * Libs update (#260) * Update tools versions * JUnit update * Feature/truth (#258) * Add Truth, update part of test classes * Convert other tests to use Truth, fix date parser test * Add Truth assertions to FormatUtilsTest, fix ktlint issue * Update assertions to a proper syntax * Add missing ThrowableViewModel (#257) * Add Error ViewModel, update title in TransactionActivity in onCreate * Switch from errors to throwable naming to have a uniform naming style * Rename toolbar title * Migrating from Travis to GH Actions (#262) * Setup GH Actions * Run only on Linux * Remove Travis File * Run only gradlew directly * Update targetSDK and Kotlin (#264) * Add stale builds canceller (#265) * Add filters * Update Gradle wrapper validation workflow * Update pre-merge workflow * Fixed various Lints (#268) * fixed typos * fixed KDocs * Replace Travis badge with GH Actions badge (#269) * Remove redundant JvmName (#274) * Fix margins and paddings for payload items (#277) * Add selective interception. (#279) * Add selective interception. * Update README.md. * Align formatting in README with other points. * Avoid header name duplication. * Strip interception header also in the no-op library. * UX improvements (#275) * Add icon for non-https transactions * Update secondary color to be more contrast * Simplify protocol resources setting * Add tests to format utils (#281) * add tests to format utils * fixes after code review * formatting fix Co-authored-by: adammasyk <adam.masyk@programisci.eu> * format utils test refactor (#285) * format utils test refactor * share text test refactor * Migrate to Kotlin Coroutines (#270) * Add coroutine as a dependency in build.gradle * Migrate AsyncTasks to kotlin coroutines * Migrate executors with the coroutines in repositories * Multi cast upstream response for Chucker consumption. (#267) * Multi cast response upstream for Chucker consumption. * Read buffer prefix before potentially gunzipping it. * Inform Chucker about unprocessed responses. * Simplify multi casting logic. * Move read offset to a variable. * Inline one-line method. * Give better control over TeeSource read results. * Add documentation to TeeSource. * Close side channel when capacity is exceeded. Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com> * Remove unnecessary mock method. (#289) * removed redundant Gson configurations (#290) * increased test coverage for format utils (#291) Co-authored-by: Karthik R <karthr@paypal.com> * added few test cases for json formatting (#295) * Properly handle unexhausted network responses (#288) * Handle properly not consumed upstream body. * Handle IO issues while reading from file. * Update dependencies (#296) * Update depencies * Update OkHttp to 3.12.10 * Handle empty and missing response bodies. (#250) * Add failing test cases. * Remove unused const. * Gzip response body if it was gunzipped. * Add test cases for regular bodies in Chucker. * Fix rule formatting. * Use proper name for application interceptor. * Return original response downstream. * Account for no content with gzip encoding. * Use Truth for Chucker tests. * Honor empty plaintext bodies. * Revert changes to HttpBinClient. * Update library/src/test/java/com/chuckerteam/chucker/ChuckerInterceptorDelegate.kt * Update library/src/main/java/com/chuckerteam/chucker/internal/support/OkHttpUtils.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com> * Add hasFixed size to RecyclerViews (#297) * Detekt to 1.7.4 (#299) * Revert "Add selective interception. (#279)" (#300) This reverts commit d14ed64. * Prepare 3.2.0 (#298) * Update versions info * Update Changelog * Fix links and update date Co-authored-by: Michał Sikora <michalsikora90@gmail.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Sergey Chelombitko <119192+technoir42@users.noreply.github.com> Co-authored-by: Michał Sikora <me@mehow.io> Co-authored-by: Hitanshu Dhawan <hitanshudhawan1996@gmail.com> Co-authored-by: adammasyk <masiol91@gmail.com> Co-authored-by: adammasyk <adam.masyk@programisci.eu> Co-authored-by: Nikhil Chaudhari <nikhyl777@gmail.com> Co-authored-by: karthik rk <karthik.rk18@gmail.com> Co-authored-by: Karthik R <karthr@paypal.com>

vbuberen added 6 commits March 5, 2020 14:07

Add stale builds canceller

f2cdbab

Testing action for builds auto-cancelling

Add default repo token

73aefa4

typo fix

70c8928

Add stale builds canceller for pre merge checks

9f97d16

Add filters

d884ac5

Add filters into pre-merge workflow

372d2db

vbuberen added the ⛔️ do not merge A PR that should not be merged label Mar 5, 2020

cortinico previously approved these changes Mar 5, 2020

View reviewed changes

vbuberen added 2 commits March 5, 2020 18:46

Update Gradle wrapper validation workflow

e90d030

Update pre-merge workflow

5728f10

vbuberen removed the ⛔️ do not merge A PR that should not be merged label Mar 5, 2020

cortinico requested changes Mar 5, 2020

View reviewed changes

cortinico approved these changes Mar 5, 2020

View reviewed changes

vbuberen added 2 commits March 5, 2020 20:24

Update branches filtering

ac751cd

Update branches filtering pre merge

71f4c8c

vbuberen merged commit 726412a into develop Mar 5, 2020

vbuberen deleted the gh_actions_cancel_redundant branch March 5, 2020 18:34

vbuberen changed the title ~~Add stale builds canceller~~ Avoid redundant builds on GH Actions Mar 5, 2020

vbuberen added this to the 3.2.0 milestone Mar 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid redundant builds on GH Actions #265

Avoid redundant builds on GH Actions #265

vbuberen commented Mar 5, 2020

vbuberen commented Mar 5, 2020

cortinico commented Mar 5, 2020

vbuberen commented Mar 5, 2020

vbuberen commented Mar 5, 2020

cortinico Mar 5, 2020

cortinico Mar 5, 2020

vbuberen Mar 5, 2020

cortinico Mar 5, 2020

vbuberen Mar 5, 2020

cortinico Mar 5, 2020

Avoid redundant builds on GH Actions #265

Avoid redundant builds on GH Actions #265

Conversation

vbuberen commented Mar 5, 2020

📄 Context

📝 Changes

⏱️ Next steps

vbuberen commented Mar 5, 2020

cortinico commented Mar 5, 2020

vbuberen commented Mar 5, 2020

vbuberen commented Mar 5, 2020

cortinico Mar 5, 2020

Choose a reason for hiding this comment

cortinico Mar 5, 2020

Choose a reason for hiding this comment

vbuberen Mar 5, 2020

Choose a reason for hiding this comment

cortinico Mar 5, 2020

Choose a reason for hiding this comment

vbuberen Mar 5, 2020

Choose a reason for hiding this comment

cortinico Mar 5, 2020

Choose a reason for hiding this comment