Add tests to format utils #281

adammasyk · 2020-03-19T18:49:51Z

📄 Context

This is my first PR. I want to help in Chucker development.

📝 Changes

Add some tests to FomatUtils class to improve test coverage

🚫 Breaking

No

⏱️ Next steps

Add more tests in next PRs! 😄

cortinico

Thanks for the first contribution @adammasyk !
I left some comments. After those we can merge this

library/src/test/java/com/chuckerteam/chucker/MockTransactionFactory.kt

library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsTest.kt

adammasyk · 2020-03-21T18:24:49Z

Ok I resolved issues from comments, I hope now it all will be ok 😄

cortinico

Just left a minor comment and then we can merge 👍

cortinico · 2020-03-21T18:29:52Z

library/src/test/java/com/chuckerteam/chucker/TestTransactionFactory.kt

+            responseContentLength = 1000L,
+            responseContentType = "application/json",
+            responseHeaders = null,
+            responseBody =


Suggested change

responseBody =

responseBody = """{"field": "value"}"""

Should also work right?

Hmm it should be something like that:
responseBody = "{\"field\": \"value\"}"
Should I fix it and add to this PR?

Sorry I've updated my suggestion. If you use """ you don't need to escape all the other quotes

Add change from your comment to my last commit and ktlint report an error:
TestTransactionFactory.kt:31:27: Missing newline after "=" (experimental:indent)

library/src/test/java/com/chuckerteam/chucker/TestTransactionFactory.kt

adammasyk · 2020-03-21T19:00:47Z

Now everything sholud be 👍

Add tests to format utils (ChuckerTeam#281)

vbuberen

Quite late for review, but anyway.

vbuberen · 2020-03-22T19:39:16Z

library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsSharedTextTest.kt

+    @Test
+    fun getShareTextForGetTransaction() {
+        Truth.assertThat(
+            FormatUtils.getShareText(contextMock, TestTransactionFactory.createTransaction("GET"), false)


I am quite late for the review, but wanted to ask to do such things in some unified way as other tests and move
FormatUtils.getShareText(contextMock, TestTransactionFactory.createTransaction("GET") in to some val named like shareText etc. like it is done in FormatUtilsTest

vbuberen · 2020-03-22T19:39:33Z

library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsSharedTextTest.kt

+    @Test
+    fun getShareTextForPostTransaction() {
+        Truth.assertThat(
+            FormatUtils.getShareText(contextMock, TestTransactionFactory.createTransaction("POST"), false)


Same as above about moving the result into variable.

library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsTest.kt

cortinico · 2020-03-22T22:47:49Z

Quite late for review, but anyway.

Agree on the suggestions. @adammasyk Are you able to followup with another PR. If not I can also do it.

adammasyk · 2020-03-23T17:08:01Z

Yes, no problem, I will do it in my next PR.

* Remove scroll flags (#210) * Fix/gradle properties (#211) * Allow Gradle parallel build * Fix version name * Fix for curl command (#214) * Fix R8 minification crash on TransactionViewModel creation. (#219) * Big resources renaming (#216) * Fix clear action crash when application is dead (#222) * Fix for crash on Save transaction action (#221) * Show warning is transaction is null, fix crash in Save action * Uncomment sample transactions * Replace mulptiple returning with multiple throw due to detekt issue * Add message into IOException, update string for request being not ready * Fix for NPE in NotificationHelper (#223) * Add additional check fo transaction being not null before getting its notificationText * Extract transaction item from transactionBuffer * ViewModel refactoring (#220) * Update ViewModel dependency, refactor TransactionViewModel * Dependencies clean up * Switch to ViewModel on the main screen * Fix depleting bytes from the response. (#226) * Use HttpUrl instead of Uri for parsing URL data. * Do not read image sources directly from the response. * Simplify gzip logic. * Move gzip checks from IoUtils to OkHttpUtils. * Remove unused 'Response.hasBody()' extension. * Update library/src/main/java/com/chuckerteam/chucker/internal/support/OkHttpUtils.kt * Revert resource renaming (#227) * Revert renaming * Add changelgos for 3.1.2 (#230) * Add missing section to release 3.1.1 and 3.1.2 (#232) * Update Github templates (#235) * Update templates * Remove redundant dot * Remove default `no` from the checkbox * Switch to platform defined HTTP code constants (#238) * Add instruction for checkbox selection (#237) * Fix HttpHeader serialization when obfuscation is enabled (#240) * Update README (#243) * Add Action to validate the Gradle Wrapper (#245) * Gradle to 6.2 (#247) * Do not refresh transaction when it is not being affected. (#246) * Do not refresh transaction when it is not being affected. * Use correct null-aware comparison for HttpTransaction. * Add switching between encoded and decoded URL formats. (#233) * Add switching between encoded and decoded URL formats. * Make URL encoding transaction specific. * Change test name for upcoming #244 PR. * Use LiveDataRecord for combineLatest tests. * Properly switch encoding and decoding URL. * Show encoding icon only when it is viable. * Add encoded URL samples to HttpBinClient. * Avoid using 'this' scoping mechanism for URL. * Fix typo in feature request comment (#251) * RTL Support (#208) * Remove ltr forcing and replace ScrollView in Overview * Replace Overview layout, add rtl support for it * Add textDirection and textAlignment property for API 21+ * Fix host textview constraints * Replace android:src with app:srcCompat * Update ids for layouts to avoid clashes * Update Material components to stable * Remove supportsRTL tag from Manifest, update Gradle plugin * Styles update * Remove supportsRTL from library manifest * Revert usage of supportVectorDrawables to avoid crashes on APIs 16-19 due to notifications icons * Fix lint issue with vector drawable * Response search fixes (#256) * Fix response search to be case insensitive * Add minimum required symbols * Fix invalid options menu in response fragment * Feature/tls info (#252) * Add UI for TLS info * Implement logic for retrieving TLS info * Address code review feedback * Switch views to ViewBinding (#253) * Switch to ViewBinding in activities * Switch to ViewBinding in ErrorsAdapter, add formattedDate field into Throwable models * Transaction adapter switch to ViewBinding * Remove variable for formatted date from models * Switch to ViewBinding in TransactionPayloadAdapter * Switch to ViewBinding in TransactionPaayload and TransactionOverviewFragments * Switch list fragments to ViewBinding * Fix link for tutorial opening * Rename views * Address code review feedback * Hide SSL field if isSSL is null * Libs update (#260) * Update tools versions * JUnit update * Feature/truth (#258) * Add Truth, update part of test classes * Convert other tests to use Truth, fix date parser test * Add Truth assertions to FormatUtilsTest, fix ktlint issue * Update assertions to a proper syntax * Add missing ThrowableViewModel (#257) * Add Error ViewModel, update title in TransactionActivity in onCreate * Switch from errors to throwable naming to have a uniform naming style * Rename toolbar title * Migrating from Travis to GH Actions (#262) * Setup GH Actions * Run only on Linux * Remove Travis File * Run only gradlew directly * Update targetSDK and Kotlin (#264) * Add stale builds canceller (#265) * Add filters * Update Gradle wrapper validation workflow * Update pre-merge workflow * Fixed various Lints (#268) * fixed typos * fixed KDocs * Replace Travis badge with GH Actions badge (#269) * Remove redundant JvmName (#274) * Fix margins and paddings for payload items (#277) * Add selective interception. (#279) * Add selective interception. * Update README.md. * Align formatting in README with other points. * Avoid header name duplication. * Strip interception header also in the no-op library. * UX improvements (#275) * Add icon for non-https transactions * Update secondary color to be more contrast * Simplify protocol resources setting * Add tests to format utils (#281) * add tests to format utils * fixes after code review * formatting fix Co-authored-by: adammasyk <adam.masyk@programisci.eu> * format utils test refactor (#285) * format utils test refactor * share text test refactor * Migrate to Kotlin Coroutines (#270) * Add coroutine as a dependency in build.gradle * Migrate AsyncTasks to kotlin coroutines * Migrate executors with the coroutines in repositories * Multi cast upstream response for Chucker consumption. (#267) * Multi cast response upstream for Chucker consumption. * Read buffer prefix before potentially gunzipping it. * Inform Chucker about unprocessed responses. * Simplify multi casting logic. * Move read offset to a variable. * Inline one-line method. * Give better control over TeeSource read results. * Add documentation to TeeSource. * Close side channel when capacity is exceeded. Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com> * Remove unnecessary mock method. (#289) * removed redundant Gson configurations (#290) * increased test coverage for format utils (#291) Co-authored-by: Karthik R <karthr@paypal.com> * added few test cases for json formatting (#295) * Properly handle unexhausted network responses (#288) * Handle properly not consumed upstream body. * Handle IO issues while reading from file. * Update dependencies (#296) * Update depencies * Update OkHttp to 3.12.10 * Handle empty and missing response bodies. (#250) * Add failing test cases. * Remove unused const. * Gzip response body if it was gunzipped. * Add test cases for regular bodies in Chucker. * Fix rule formatting. * Use proper name for application interceptor. * Return original response downstream. * Account for no content with gzip encoding. * Use Truth for Chucker tests. * Honor empty plaintext bodies. * Revert changes to HttpBinClient. * Update library/src/test/java/com/chuckerteam/chucker/ChuckerInterceptorDelegate.kt * Update library/src/main/java/com/chuckerteam/chucker/internal/support/OkHttpUtils.kt Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Volodymyr Buberenko <vbuberen@users.noreply.github.com> * Add hasFixed size to RecyclerViews (#297) * Detekt to 1.7.4 (#299) * Revert "Add selective interception. (#279)" (#300) This reverts commit d14ed64. * Prepare 3.2.0 (#298) * Update versions info * Update Changelog * Fix links and update date Co-authored-by: Michał Sikora <michalsikora90@gmail.com> Co-authored-by: Nicola Corti <corti.nico@gmail.com> Co-authored-by: Sergey Chelombitko <119192+technoir42@users.noreply.github.com> Co-authored-by: Michał Sikora <me@mehow.io> Co-authored-by: Hitanshu Dhawan <hitanshudhawan1996@gmail.com> Co-authored-by: adammasyk <masiol91@gmail.com> Co-authored-by: adammasyk <adam.masyk@programisci.eu> Co-authored-by: Nikhil Chaudhari <nikhyl777@gmail.com> Co-authored-by: karthik rk <karthik.rk18@gmail.com> Co-authored-by: Karthik R <karthr@paypal.com>

adammasyk force-pushed the format_utils_test branch 2 times, most recently from fa1fd9e to 086d487 Compare March 19, 2020 19:07

add tests to format utils

62b120a

adammasyk force-pushed the format_utils_test branch from 086d487 to 62b120a Compare March 19, 2020 19:11

adammasyk changed the title ~~add tests to format utils~~ Add tests to format utils Mar 19, 2020

cortinico requested changes Mar 21, 2020

View reviewed changes

adammasyk force-pushed the format_utils_test branch 4 times, most recently from aba6675 to 2dc8adb Compare March 21, 2020 18:19

cortinico approved these changes Mar 21, 2020

View reviewed changes

cortinico added this to the 3.2.0 milestone Mar 21, 2020

cortinico added the enhancement New feature or improvement to the library label Mar 21, 2020

fixes after code review

244c08d

adammasyk force-pushed the format_utils_test branch from 2dc8adb to 244c08d Compare March 21, 2020 18:43

cortinico requested changes Mar 21, 2020

View reviewed changes

library/src/test/java/com/chuckerteam/chucker/TestTransactionFactory.kt Show resolved Hide resolved

library/src/test/java/com/chuckerteam/chucker/TestTransactionFactory.kt Outdated Show resolved Hide resolved

formatting fix

855875d

cortinico approved these changes Mar 21, 2020

View reviewed changes

cortinico merged commit c343002 into ChuckerTeam:develop Mar 21, 2020

adammasyk added a commit to adammasyk/chucker that referenced this pull request Mar 22, 2020

Merge pull request #1 from ChuckerTeam/develop

60c25a8

Add tests to format utils (ChuckerTeam#281)

adammasyk mentioned this pull request Mar 22, 2020

Merge pull request #1 from ChuckerTeam/develop #283

Closed

vbuberen reviewed Mar 22, 2020

View reviewed changes

adammasyk mentioned this pull request Mar 23, 2020

format utils test refactor #285

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests to format utils #281

Add tests to format utils #281

adammasyk commented Mar 19, 2020

cortinico left a comment

adammasyk commented Mar 21, 2020

cortinico left a comment

cortinico Mar 21, 2020 •

edited

Loading

adammasyk Mar 21, 2020

cortinico Mar 21, 2020

adammasyk Mar 21, 2020

adammasyk commented Mar 21, 2020

vbuberen left a comment

vbuberen Mar 22, 2020

vbuberen Mar 22, 2020

cortinico commented Mar 22, 2020

adammasyk commented Mar 23, 2020

Add tests to format utils #281

Add tests to format utils #281

Conversation

adammasyk commented Mar 19, 2020

📄 Context

📝 Changes

🚫 Breaking

⏱️ Next steps

cortinico left a comment

Choose a reason for hiding this comment

adammasyk commented Mar 21, 2020

cortinico left a comment

Choose a reason for hiding this comment

cortinico Mar 21, 2020 • edited Loading

Choose a reason for hiding this comment

adammasyk Mar 21, 2020

Choose a reason for hiding this comment

cortinico Mar 21, 2020

Choose a reason for hiding this comment

adammasyk Mar 21, 2020

Choose a reason for hiding this comment

adammasyk commented Mar 21, 2020

vbuberen left a comment

Choose a reason for hiding this comment

vbuberen Mar 22, 2020

Choose a reason for hiding this comment

vbuberen Mar 22, 2020

Choose a reason for hiding this comment

cortinico commented Mar 22, 2020

adammasyk commented Mar 23, 2020

cortinico Mar 21, 2020 •

edited

Loading