Force all layouts to be LTR #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developing full support for RTL would require to adapt all the ViewPagers/TabLayouts to work correctly. I'm currently fixing all the layouts to LTR and we'll wait for ViewPager2 to provide full RTL support. Fixes #117
redwarp
reviewed
Sep 20, 2019
There was a problem hiding this comment.
Have you tried writing in the manifest android:supportRtl="false"?
I think it might work. https://android-developers.googleblog.com/2013/03/native-rtl-support-in-android-42.html
Yes. This will break the build because of Manifest merging if the user of the library applies |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developing full support for RTL would require to adapt all
the ViewPagers/TabLayouts to work correctly. I'm currently
fixing all the layouts to LTR and we'll wait for ViewPager2
to provide full RTL support.
Fixes #117