Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better RTL support #117

Closed
eitanaviv opened this issue Sep 18, 2019 · 5 comments · Fixed by #121 or #208
Closed

Better RTL support #117

eitanaviv opened this issue Sep 18, 2019 · 5 comments · Fixed by #121 or #208
Assignees
Labels
bug Something isn't working enhancement New feature or improvement to the library
Milestone

Comments

@eitanaviv
Copy link

Is your feature request related to a problem? Please describe.
It would be nicer if Chucker could have a better support for RTL devices.

Describe the solution you'd like
ViewPager works the opposite way on RTL layout and some texts are overlapping each other.

Describe alternatives you've considered
Better RTL support.

Additional context
Screenshot_1568793405
Screenshot_1568793426

Do you want to develop this feature yourself?
No unfortunately.

cortinico added a commit that referenced this issue Sep 19, 2019
Developing full support for RTL would require to adapt all
the ViewPagers/TabLayouts to work correctly. I'm currently
fixing all the layouts to LTR and we'll wait for ViewPager2
to provide full RTL support.

Fixes #117
@cortinico
Copy link
Member

Thanks for the report @eitanaviv

Having full support for RTL will require to update the ViewPagers and TabLayouts to handle both LTR and RTL.

To fix your situation, I've currently forced all the layouts to be LTR. This will prevent strings from overlapping and will make sure the ViewPagers are working in the right direction.
Once ViewPager2 will be released and stable, we can consider providing full RTL support.

@cortinico cortinico self-assigned this Sep 19, 2019
@cortinico cortinico added the bug Something isn't working label Sep 19, 2019
@cortinico cortinico added this to the 3.1.0 milestone Sep 19, 2019
redwarp pushed a commit that referenced this issue Sep 20, 2019
Developing full support for RTL would require to adapt all
the ViewPagers/TabLayouts to work correctly. I'm currently
fixing all the layouts to LTR and we'll wait for ViewPager2
to provide full RTL support.

Fixes #117
@vbuberen
Copy link
Collaborator

Would like to reopen and assign myself to this issue. Going to update my #159 with RTL support, since forcing LTR isn't an option in long-time perspective. Targeting for 3.2.0 for release.

@vbuberen vbuberen reopened this Jan 23, 2020
@vbuberen vbuberen modified the milestones: 3.1.0, 3.2.0 Jan 23, 2020
@vbuberen vbuberen assigned vbuberen and unassigned cortinico Jan 23, 2020
@vbuberen vbuberen added the work-in-progress This Issue/PR is currently under development label Jan 23, 2020
@vbuberen
Copy link
Collaborator

There are some serious changes to be done in layouts, like Overview tab, so decided to make it in a separate branch to not mix with ViewPager2 code updates.

@vbuberen vbuberen mentioned this issue Jan 25, 2020
@vbuberen
Copy link
Collaborator

Hi @eitanaviv
Am I right that you use RTL on a daily basis?
If so, I would like to ask you to help me a little bit by providing feedback on my implementation of RTL support.
You can try it out by adding a snapshot as dependency into your app:
implementation 'com.github.ChuckerTeam:Chucker:feature~rtl_support-SNAPSHOT'

Also, I would like to ask how the response body in Response tab should look like. Should it be mirrored as well?

@ghost ghost added the Pending PR The resolution for the issue is in PR label Feb 25, 2020
@vbuberen
Copy link
Collaborator

Closing this issue, since #208 is already merged. In case any troubles found with updated RTL implementation - open new issues.

@vbuberen vbuberen added enhancement New feature or improvement to the library and removed Pending PR The resolution for the issue is in PR work-in-progress This Issue/PR is currently under development labels Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or improvement to the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants