Fix Bug when Creating Bars in ETABS21 #483
Conversation
Since Area objects have the diffload defined in the 3-3 Axis, the corresponding Type Number is 3...not 2.
In line with what already done with PierForce
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
…ETABS_Toolkit-#430-AddSpandrelForceResult
No Von Mises Flexural Moment gets extracted since it's not a direct output given by ETABS. It could be possibly computed within the BHoM in case it's required.
The Von Mises Moment is not returned by ETABS natively and it must be computed directly in the BHoM from the Von Mises stresses diagram.
Duplication removed.
Thickness of panels is extracted differently depending on the type of deck/slab/wall section property assigned to the panel. The ETABS API provides different functions for each of their types and they must be all called somehow until the correct one gets hit. The control parameter is the integer ouput ret of the ETABS API functions (0=Worked Fine, 1=Failed)
Rather than moving each node one by one, all nodes are grouped into different buckets based on same movement in x/y/z direction. In this way, it is possible to call the .move() method on multiple nodes rather than on a single node at the time. This makes the algorithm much faster taking advantage of the pros of the Hash Tables data structure.
|
@peterjamesnugent, I've added the new ETABS 21 Release to the Installer. Below the link to the Pull Request |
|
@GCRA101 as discussed to add altconfigs to installer and update preprocessor directives to |
|
@BHoMBot check installer |
|
@Chrisshort92 to confirm, the following actions are now queued:
|
|
@BHoMBot Check Installer |
|
@Chrisshort92 to confirm, the following actions are now queued:
|
1 similar comment
…//github.com/BHoM/ETABS_Toolkit into ETABS_Toolkit-#482-FixBugCreatingBarsETABS21
There was a problem hiding this comment.
I had a look into this and although a separate build configuration could help resolve this problem, it is something I think we want to stray away from as much as possible. Ideally there should not be any separate build configurations at all except debug and release.
Reason it has been done before was out of neccesity though to different names of the ETABS api dlls, and change on method interfaces that required these directives to go everywhere, but as this is not the case now, I think we rather solve this runtime than compile time.
Instead of adding this additional configuration, and all compiler directives that comes with it, I think we can simply get out the version of the currently runnign ETABS model. Had a first check, and
string modelVersion = "";
double doubleVer = 0;
m_app.SapModel.GetVersion(ref modelVersion, ref doubleVer);
Is giving back the version of the currently running model. We can extract this in the constructor of the ETABS adapter and store it, and then simply have a normal if statement at the position in the code that is causing the problem (think it was insertion points for Bars if I am not mistaken).
Also, not sure exactly what has happened to this branch, but it is currently looking like it is containing commits from more or less everything that has gone in to develop since the past 3 months which makes it impossible to review unfortunately, so would suggest starting fresh from a new branch from develop and get the code fix added to that branch, with the suggested chage from here as well, basically, start from scratch with a new PR and branch, lift over the parts you need, then delete this PR and branch.
Happy with a quick call about this if it helps.
|
@IsakNaslundBh , @peterjamesnugent , I've created the new branch incorporating the above at the following link: #487 |
Issues addressed by this PR
Closes #482
ETABS Toolkit now able to push bars to ETABS 21 by skipping not-working API function by using a new Debug21 Configuration.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23483-FixBugWhenCreatingBarsInETABS21/BHoM%207.3.1%20Test%20-%20Bar%20Object%20Push%20to%20ETABS%2021%201.gh?csf=1&web=1&e=LaeSMJ
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23483-FixBugWhenCreatingBarsInETABS21/Test%20ETABS%20Model.EDB?csf=1&web=1&e=boM6fg
Changelog