-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue with Pushing Levels by using PriorityTypes #480
Fix Issue with Pushing Levels by using PriorityTypes #480
Conversation
…BHoM_Adapter-#390-AddPriorityTypesForPush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TO align with suggested changes in the BHoM_Adapter
Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
Requested changes now addressed. Dismissing my request for change review
Happy with this from a code perspective now, and have dismissed my review. @Chrisshort92 Could you please assist in testing this from a functionality point of view? |
@HugoVanLooveren to complete a functionality review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with ETABS 21 & 19
Used BHoM Version 7.2.1.0
With 19 it all worked (opened clean ETABS file, as the example file was for 20)
With 21, the levels got pushed, however, only 1 bar got pushed.
Got this error:
- This component failed to run properly.
- Error: Unable to cast object of type 'System.Boolean' to type 'System.Double[]'.
- Occured in BH.UI.Base.Caller.Run(List`1 inputs)
called from BH.UI.Base.Caller.Run() - Are you sure you have the correct type of inputs? Check their description for more details.
@GCRA101 & @peterjamesnugent |
@BHoMBot check required |
@GCRA101 to confirm, the following actions are now queued:
|
@BHoMBot check copyright-compliance |
@GCRA101 to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
The check |
The check |
ETABS21 is being covered in a seperate PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on @HugoVanLooveren's review, and the issue with Etabs21 being covered in a seperate PR:
#483
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
NOTE: Depends on
BHoM/BHoM_Adapter#393
Issues addressed by this PR
Closes #435
ETABS Toolkit now able to push objects and levels together by using priorities on top of dependencies for sorting the objects to push.
Test files
Video Demonstration - Issue
https://burohappold.sharepoint.com/:v:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Push%20Levels%20Issue.mp4?csf=1&web=1&e=7cEacd
Video Demonstration - Solution
https://burohappold.sharepoint.com/:v:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Push%20Levels%20Sorted.mp4?csf=1&web=1&e=cDUbje
Json File
https://burohappold.sharepoint.com/sites/BHoM/_layouts/15/download.aspx?UniqueId=aa695dbddee44123b35aecc6843d658a&e=mvnMou
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Test%20Script.gh?csf=1&web=1&e=Lzfzec
Etabs File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23480-AddPriorityTypesForPush/Test%20ETABS%20Model.EDB?csf=1&web=1&e=lj7JY7
Changelog