-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Mesh VonMises Stresses #471
Extract Mesh VonMises Stresses #471
Conversation
No Von Mises Flexural Moment gets extracted since it's not a direct output given by ETABS. It could be possibly computed within the BHoM in case it's required.
The Von Mises Moment is not returned by ETABS natively and it must be computed directly in the BHoM from the Von Mises stresses diagram.
Thickness of panels is extracted differently depending on the type of deck/slab/wall section property assigned to the panel. The ETABS API provides different functions for each of their types and they must be all called somehow until the correct one gets hit. The control parameter is the integer ouput ret of the ETABS API functions (0=Worked Fine, 1=Failed)
@IsakNaslundBh, @Chrisshort92 , @peterjamesnugent, just to be clear, this Pull Request is for the next BHoM 7.4 Milestone in autumn. Not the one coming up now in september. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality Tested with provided test files and working as expected. approved for merge
@BHoMBot check required |
@Chrisshort92 sorry, I didn't understand. |
@Chrisshort92 to confirm, the following actions are now queued:
There are 64 requests in the queue ahead of you. |
@BHoMBot check versioning |
@peterjamesnugent to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check copyright-compliance |
@GCRA101 to confirm, the following actions are now queued:
There are 30 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be calculating the vonMises moment, everything is there for the user to do it themselves - if ETABS doesn't allow us to pull it, we shoudn't calculated it for the user.
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you've removed the two suggestions, I am happy from a code perspective.
Can @Chrisshort92 review from a functionality perspective please.
@peterjamesnugent to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy my comments have been reflected in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with BHoM Beta 7.2.1
Tested with ETABS 21
Despite not having used the von Mises in ETABS before, it worked fine. Checked the values in ETABS table with the numerical outputs.
The visible mesh output also was the same when displayed in ETABS (using max/min values)
So all good :)
@BHoMBot check ready-to-merge |
@peterjamesnugent to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #463
ETABS Toolkit now can allow to extract Shell Von Mises Stress outputs from ETABS.
Test files
Files Folder
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23471-ExtractMeshVonMisesStresses?csf=1&web=1&e=OpP1iW
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23471-ExtractMeshVonMisesStresses/Test%20Script.gh?csf=1&web=1&e=AFd4Si
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23471-ExtractMeshVonMisesStresses/Test%20ETABS%20Model.EDB?csf=1&web=1&e=6fgDcc
Excel File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23471-ExtractMeshVonMisesStresses/Test%20ETABS%20Model.EDB?csf=1&web=1&e=6fgDcc
Changelog