Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Mesh VonMises Stresses #471

Merged

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Sep 10, 2024

No Von Mises Flexural Moment gets extracted since it's not a direct output given by ETABS.
It could be possibly computed within the BHoM in case it's required.
The Von Mises Moment is not returned by ETABS natively and it must be computed directly in the BHoM from the Von Mises stresses diagram.
Thickness of panels is extracted differently depending on the type of deck/slab/wall section property assigned to the panel.
The ETABS API provides different functions for each of their types and they must be all called somehow until the correct one gets hit.
The control parameter is the integer ouput ret of the ETABS API functions (0=Worked Fine, 1=Failed)
@GCRA101 GCRA101 added type:feature New capability or enhancement status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Sep 10, 2024
@GCRA101 GCRA101 added this to the BHoM 7.4 β MVP milestone Sep 10, 2024
@GCRA101 GCRA101 self-assigned this Sep 10, 2024
@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 10, 2024

@IsakNaslundBh, @Chrisshort92 , @peterjamesnugent, just to be clear, this Pull Request is for the next BHoM 7.4 Milestone in autumn. Not the one coming up now in september. ;)

@peterjamesnugent peterjamesnugent removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Oct 1, 2024
Chrisshort92
Chrisshort92 previously approved these changes Oct 14, 2024
Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality Tested with provided test files and working as expected. approved for merge

@Chrisshort92
Copy link
Contributor

Chrisshort92 commented Oct 14, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Oct 14, 2024

@Chrisshort92 sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

Copy link

bhombot-ci bot commented Oct 14, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 64 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Oct 24, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check versioning

There are 11 requests in the queue ahead of you.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2024

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Oct 28, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

There are 30 requests in the queue ahead of you.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 28, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be calculating the vonMises moment, everything is there for the user to do it themselves - if ETABS doesn't allow us to pull it, we shoudn't calculated it for the user.

Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/ETABSAdapter.cs Outdated Show resolved Hide resolved
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
GCRA101 and others added 2 commits November 4, 2024 10:15
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've removed the two suggestions, I am happy from a code perspective.

Can @Chrisshort92 review from a functionality perspective please.

Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
Etabs_Adapter/CRUD/Read/Results/MeshResults.cs Outdated Show resolved Hide resolved
@peterjamesnugent
Copy link
Member

@BHoMBot check required
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Nov 13, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

There are 19 requests in the queue ahead of you.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy my comments have been reflected in the PR.

Copy link

@HugoVanLooveren HugoVanLooveren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with BHoM Beta 7.2.1
Tested with ETABS 21

Despite not having used the von Mises in ETABS before, it worked fine. Checked the values in ETABS table with the numerical outputs.
The visible mesh output also was the same when displayed in ETABS (using max/min values)

So all good :)

@peterjamesnugent
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 14, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent merged commit efd36e5 into develop Nov 14, 2024
10 checks passed
@peterjamesnugent peterjamesnugent deleted the ETABS_Toolkit-#463-AddVonMisesStressesExtraction branch November 14, 2024 17:39
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to Extract Mesh VonMises Stresses
4 participants