-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get ETABS File Path #478
Get ETABS File Path #478
Conversation
Testing against the following test scripts as link in PR above is not live; https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23478-GetEtabsFilePath?csf=1&web=1&e=Z4BiJY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality tested against test files in https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23478-GetEtabsFilePath?csf=1&web=1&e=Z4BiJY. Working as expected, approved for merge
@BHoMBot check required |
@Chrisshort92 to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
@BHoMBot check copyright-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 29 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change needed, and maybe some further testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes since @Chrisshort92 review do not affect functionality, so approving.
@peterjamesnugent to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
@BHoMBot check installer |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #413
ETABS Toolkit now allows to retrieve the full filepath of the ETABS Model as a public attribute of the ETABSAdapter class.
Test files
Grasshopper File
ETABS File
Changelog