Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ETABS File Path #478

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Sep 30, 2024

Issues addressed by this PR

Closes #413

GH Script - Canvas View

ETABS Toolkit now allows to retrieve the full filepath of the ETABS Model as a public attribute of the ETABSAdapter class.

Test files

Grasshopper File

ETABS File

Changelog

  • Added public and read-only attribute FilePath to the ETABSAdapter Class
  • Added assignment of the FilePath attribute in the Constructor of the ETABSAdapter Class

@GCRA101 GCRA101 added the type:feature New capability or enhancement label Sep 30, 2024
@GCRA101 GCRA101 added this to the BHoM 7.4 β MVP milestone Sep 30, 2024
@GCRA101 GCRA101 self-assigned this Sep 30, 2024
@GCRA101 GCRA101 changed the title Etabs toolkit #413 get etabs file path Get ETABS File Path Sep 30, 2024
@Chrisshort92
Copy link
Contributor

Chrisshort92
Chrisshort92 previously approved these changes Oct 13, 2024
Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chrisshort92
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Oct 13, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 10 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Oct 23, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

There are 29 requests in the queue ahead of you.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 28, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change needed, and maybe some further testing.

ETABS_oM/ETABS_oM.csproj Outdated Show resolved Hide resolved
Etabs_Adapter/ETABSAdapter.cs Show resolved Hide resolved
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes since @Chrisshort92 review do not affect functionality, so approving.

@peterjamesnugent
Copy link
Member

@BHoMBot check required
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Nov 7, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

There are 14 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 8, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

@GCRA101
Copy link
Contributor Author

GCRA101 commented Nov 11, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 11, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit 1ec4bc2 into develop Nov 13, 2024
10 checks passed
@peterjamesnugent peterjamesnugent deleted the ETABS_Toolkit-#413-GetETABSFilePath branch November 13, 2024 17:54
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETABS filname/filepath
3 participants