Improve Move Objects Update Feature #476
Conversation
Rather than moving each node one by one, all nodes are grouped into different buckets based on same movement in x/y/z direction. In this way, it is possible to call the .move() method on multiple nodes rather than on a single node at the time. This makes the algorithm much faster taking advantage of the pros of the Hash Tables data structure.
|
@BHoMBot check required |
|
@Chrisshort92 to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
|
@BHoMBot check copyright-compliance |
|
@peterjamesnugent to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@GCRA101 to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Happy from a code side, @Chrisshort92 can you do a functionality review please.
Actually, given the previous approving review from Chris: #476 (review) and the changes after that were purely variable name changes and removal of commented code - this can be merged,
|
@peterjamesnugent to confirm, the following actions are now queued:
|
|
@BHoMBot check installer |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
|
@BHoMBot check ready-to-merge |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #464
ETABS Toolkit now able to perform translational movement of ETABS models upon Update Request much faster than before (up to 7 times faster as per Test ETABS model below - i.e.: from 7 minutes to 1 minute max).
Whenever rotations or distorsions of ETABS objects are concerned, unfortunately ETABS API limitations still prevent BHoM from carrying out a correct update of ETABS panel objects.
More work is required to find out a solution to this problem.
Test files
Video Demonstration - Issue
https://burohappold.sharepoint.com/:v:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23476-ImproveMoveObjectsAlgorithm/Moving%20BHoM%20Algorithm%20Issue.mp4?csf=1&web=1&e=XrufhL
Video Demonstration - Solution
https://burohappold.sharepoint.com/:v:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23476-ImproveMoveObjectsAlgorithm/Moving%20BHoM%20Algorithm%20Sorted.mp4?csf=1&web=1&e=ZlxeGo
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23476-ImproveMoveObjectsAlgorithm/[TestScript.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23476-ImproveMoveObjectsAlgorithm/TestScript.gh?csf=1&web=1&e=1smiHN)?csf=1&web=1&e=1smiHN
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23476-ImproveMoveObjectsAlgorithm/Test%20ETABS%20Model.EDB?csf=1&web=1&e=X61Bhi
Changelog