Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more re-exports and use EnumOrLiteral from core #133

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Conversation

yen-tt
Copy link
Collaborator

@yen-tt yen-tt commented Aug 17, 2022

export Address and ComplexUrl interface from core as well
remove EnumOrLiteral from headless, and use the one from core instead.

J=SLAP-2324

@yen-tt yen-tt requested a review from a team as a code owner August 17, 2022 16:07
@coveralls
Copy link

coveralls commented Aug 17, 2022

Pull Request Test Coverage Report for Build 2876908517

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.2%

Totals Coverage Status
Change from base Build 2876494946: 0.0%
Covered Lines: 341
Relevant Lines: 359

💛 - Coveralls

@yen-tt yen-tt requested a review from nmanu1 August 17, 2022 16:36
@yen-tt yen-tt changed the title export Address and use EnumOrLiteral from core more re-exports and use EnumOrLiteral from core Aug 17, 2022
src/search-core-re-exports.ts Outdated Show resolved Hide resolved
@yen-tt yen-tt merged commit a1f0d44 into develop Aug 17, 2022
@yen-tt yen-tt deleted the dev/bump-version branch August 17, 2022 16:49
@yen-tt yen-tt mentioned this pull request Sep 7, 2022
yen-tt added a commit that referenced this pull request Sep 8, 2022
## Version 2.0.0

### Breaking Changes
- Re-exported all modified and newly added direct answer related interfaces from search-core V2. (#131 #133 #136 ) 
  - More details of the changes are listed in [search-core v2 release notes](https://github.com/yext/search-core/releases/tag/v2.0.0)
- Restructured static filters state to allow user to store more complex combination of static filters as well as field value filters. `SelectableFilter` interface is replaced with `SelectableStaticFilter`, which uses the new `StaticFilter` interface from search-core V2. The static filters state now accepts an array of `SelectableStaticFilter`. (#130 )
- All exports marked as `@deprecated` in previous version(s) as part of a rebranding process is now removed in V2 (#132  )
  - for more details, the removed deprecated identifiers are listed in [v1.3 release notes](https://github.com/yext/search-headless/releases/tag/v1.3.0)
@yen-tt yen-tt mentioned this pull request Sep 8, 2022
yen-tt added a commit that referenced this pull request Sep 8, 2022
## Version 2.0.0

### Breaking Changes
- Re-exported all modified and newly added direct answer related interfaces from search-core V2. (#131 #133 #136 ) 
  - More details of the changes are listed in [search-core v2 release notes](https://github.com/yext/search-core/releases/tag/v2.0.0)
- Restructured static filters state to allow user to store more complex combination of static filters as well as field value filters. `SelectableFilter` interface is replaced with `SelectableStaticFilter`, which uses the new `StaticFilter` interface from search-core V2. The static filters state now accepts an array of `SelectableStaticFilter`. (#130 )
- All exports marked as `@deprecated` in previous version(s) as part of a rebranding process is now removed in V2 (#132  )
  - for more details, the removed deprecated identifiers are listed in [v1.3 release notes](https://github.com/yext/search-headless/releases/tag/v1.3.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants