re-export DA interfaces from search-core #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2875962594Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
214dbea to
7212ff3
Compare
oshi97
reviewed
Aug 17, 2022
| @@ -7,7 +7,7 @@ it('can select a facet option', () => { | |||
| const [initialState, facetOption] = createInitialState(false); | |||
| const answers = createMockedHeadless({}, initialState); | |||
| answers.setFacetOption('testFieldId', facetOption, true); | |||
| expect(answers.state.filters.facets[0].options[0]).toEqual({ | |||
| expect(answers.state.filters.facets?.[0].options[0]).toEqual({ | |||
There was a problem hiding this comment.
Out of curiosity did these TS issues come from a previous commit?
There was a problem hiding this comment.
yup, I can see these TS issues when I switch to develop branch just now. Edit: the TS issue in integration/directAnswer.ts is from the version bump in this pr tho. Everything else come from previous commit
oshi97
approved these changes
Aug 17, 2022
nmanu1
reviewed
Aug 17, 2022
Merged
yen-tt
added a commit
that referenced
this pull request
Sep 8, 2022
## Version 2.0.0 ### Breaking Changes - Re-exported all modified and newly added direct answer related interfaces from search-core V2. (#131 #133 #136 ) - More details of the changes are listed in [search-core v2 release notes](https://github.com/yext/search-core/releases/tag/v2.0.0) - Restructured static filters state to allow user to store more complex combination of static filters as well as field value filters. `SelectableFilter` interface is replaced with `SelectableStaticFilter`, which uses the new `StaticFilter` interface from search-core V2. The static filters state now accepts an array of `SelectableStaticFilter`. (#130 ) - All exports marked as `@deprecated` in previous version(s) as part of a rebranding process is now removed in V2 (#132 ) - for more details, the removed deprecated identifiers are listed in [v1.3 release notes](https://github.com/yext/search-headless/releases/tag/v1.3.0)
Merged
yen-tt
added a commit
that referenced
this pull request
Sep 8, 2022
## Version 2.0.0 ### Breaking Changes - Re-exported all modified and newly added direct answer related interfaces from search-core V2. (#131 #133 #136 ) - More details of the changes are listed in [search-core v2 release notes](https://github.com/yext/search-core/releases/tag/v2.0.0) - Restructured static filters state to allow user to store more complex combination of static filters as well as field value filters. `SelectableFilter` interface is replaced with `SelectableStaticFilter`, which uses the new `StaticFilter` interface from search-core V2. The static filters state now accepts an array of `SelectableStaticFilter`. (#130 ) - All exports marked as `@deprecated` in previous version(s) as part of a rebranding process is now removed in V2 (#132 ) - for more details, the removed deprecated identifiers are listed in [v1.3 release notes](https://github.com/yext/search-headless/releases/tag/v1.3.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump headless version to 2.0.0-alpha.131, to be publish after this pr is merged
J=SLAP-2324
TEST=none