Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0.0 #139

Merged
merged 10 commits into from
Sep 8, 2022
Merged

V2.0.0 #139

merged 10 commits into from
Sep 8, 2022

Conversation

yen-tt
Copy link
Collaborator

@yen-tt yen-tt commented Sep 8, 2022

Version 2.0.0

Breaking Changes

alextaing and others added 10 commits July 27, 2022 13:40
This PR makes the static filters state more flexible, so users can store more complex static filters as well as field value filters. It incorporates the changes in the Core models, including the new `StaticFilter` interface. The `SelectableFilter` interface is replaced with `SelectableStaticFilter` and the static filters state now accepts an array of the latter type. The Jest tests were updated to reflect these changes and to test that the new functionality works as expected.

J=SLAP-2326
TEST=auto, manual

See that the new and existing Jest tests pass. From the Node test-site, store static filters in State and run vertical searches. See that they execute successfully and give the correct results.
- update search-core version to be 2.0.0-alpha.215 which the new DA interfaces. re-export those DA interfaces in headless.
- fix some new TS issues in DA jest test and existing issues in facets and verticalSearch test.

bump headless version to 2.0.0-alpha.131, to be publish after this pr is merged

J=SLAP-2324
TEST=none
export Address and ComplexUrl interface from core as well
remove EnumOrLiteral from headless, and use the one from core instead. 

J=SLAP-2324
This PR removes any code that's marked deprecated as part of renaming and uses the newest alpha of core where all deprecated code is removed.

J=SLAP-2331
TEST=manual

Test: removed code that's tagged deprecated and files named deprecate, updated the documentations, and searched 'deprecate', 'answers', as well as all identifiers in Cindy's renaming prs. Also renamed any deprecated identifiers in past prs that still remain in the document (AnswersHeadless -> SearchHeadless, AnswersCore -> SearchCore). Updated to the newest alpha version to confirm any deprecated re-exports are removed.
This PR bumps the version to 2.0.0-alpha.134 after the deletion of all deprecated code.

TEST=auto
beta version for QA related to DA and StaticFilters changes
re-export HoursDirectAnswer interfaces from [core pr](yext/search-core#220)
bump alpha version to use in component lib

J=SLAP-2359
@yen-tt yen-tt requested a review from a team as a code owner September 8, 2022 21:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3018444728

  • 36 of 37 (97.3%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 93.173%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/filter-creators.ts 6 7 85.71%
Totals Coverage Status
Change from base Build 2747658909: 0.4%
Covered Lines: 339
Relevant Lines: 357

💛 - Coveralls

@yen-tt yen-tt merged commit f0f6319 into main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants