Version 2.0.0 #137
Merged
Version 2.0.0 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main (v1.4.0) into develop
This PR makes the static filters state more flexible, so users can store more complex static filters as well as field value filters. It incorporates the changes in the Core models, including the new `StaticFilter` interface. The `SelectableFilter` interface is replaced with `SelectableStaticFilter` and the static filters state now accepts an array of the latter type. The Jest tests were updated to reflect these changes and to test that the new functionality works as expected. J=SLAP-2326 TEST=auto, manual See that the new and existing Jest tests pass. From the Node test-site, store static filters in State and run vertical searches. See that they execute successfully and give the correct results.
- update search-core version to be 2.0.0-alpha.215 which the new DA interfaces. re-export those DA interfaces in headless. - fix some new TS issues in DA jest test and existing issues in facets and verticalSearch test. bump headless version to 2.0.0-alpha.131, to be publish after this pr is merged J=SLAP-2324 TEST=none
export Address and ComplexUrl interface from core as well remove EnumOrLiteral from headless, and use the one from core instead. J=SLAP-2324
This PR removes any code that's marked deprecated as part of renaming and uses the newest alpha of core where all deprecated code is removed. J=SLAP-2331 TEST=manual Test: removed code that's tagged deprecated and files named deprecate, updated the documentations, and searched 'deprecate', 'answers', as well as all identifiers in Cindy's renaming prs. Also renamed any deprecated identifiers in past prs that still remain in the document (AnswersHeadless -> SearchHeadless, AnswersCore -> SearchCore). Updated to the newest alpha version to confirm any deprecated re-exports are removed.
This PR bumps the version to 2.0.0-alpha.134 after the deletion of all deprecated code. TEST=auto
beta version for QA related to DA and StaticFilters changes
re-export HoursDirectAnswer interfaces from [core pr](yext/search-core#220) bump alpha version to use in component lib J=SLAP-2359
Pull Request Test Coverage Report for Build 3018073418Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
will update headless and core version to 2.0.0 once core version v2 is released. |
oshi97
previously approved these changes
Sep 7, 2022
oshi97
approved these changes
Sep 8, 2022
|
should the DA stuff also go under breaking changes? I think if people are extending the existing models, their stuff would break with the changes |
updated description! Also linked to search-core v2 for more info of the changes |
nit: capital r at the beginning to be consistent |
nmanu1
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0.0
Breaking Changes
SelectableFilterinterface is replaced withSelectableStaticFilter, which uses the newStaticFilterinterface from search-core V2. The static filters state now accepts an array ofSelectableStaticFilter. (Expand static filters #130 )@deprecatedin previous version(s) as part of a rebranding process is now removed in V2 (remove deprecated code #132 )