Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor menu styling #2919

Merged
merged 18 commits into from
Jan 21, 2025
Merged

Refactor menu styling #2919

merged 18 commits into from
Jan 21, 2025

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Dec 11, 2024 •
edited
Loading

Description

Current State:

The CrudMoreActionsMenu contains quite a bit of custom styling. Ideally, this shouldn't be necessary.

Therefor move the custom styling from the component (applied via sx props) to the theme wherever it is possible and makes sense:

  • Divider (only in Menus)
  • MenuItem
  • ListItemIcon

Acceptance criteria

Screenshots/screencasts

Before After
Before After

Further information

@juliawegmayr juliawegmayr changed the base branch from main to next December 11, 2024 13:40
@juliawegmayr juliawegmayr self-assigned this Dec 31, 2024
@juliawegmayr juliawegmayr marked this pull request as ready for review December 31, 2024 09:20
@auto-assign auto-assign bot requested a review from johnnyomair December 31, 2024 09:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

jamesricky
jamesricky previously approved these changes Jan 21, 2025
View reviewed changes
johnnyomair
johnnyomair requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved.

@johnnyomair johnnyomair removed the request for review from jamesricky January 21, 2025 14:23
@johnnyomair johnnyomair merged commit e4bdeb9 into next Jan 21, 2025
11 checks passed
@johnnyomair johnnyomair deleted the refactor-menu-styling branch January 21, 2025 14:37
@johnnyomair johnnyomair mentioned this pull request Feb 5, 2025
Merged
This was referenced Feb 5, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

@jamesricky jamesricky jamesricky left review comments

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliawegmayr @jamesricky @johnnyomair