Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add stories for createCompositeBlockSelectField #3345

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

johnnyomair
Copy link
Collaborator

Description

Showcases basic and with icon variants.

Showcases basic and with icon variants.
@johnnyomair johnnyomair requested a review from stekalt February 5, 2025 10:08
@johnnyomair johnnyomair self-assigned this Feb 5, 2025
@johnnyomair
Copy link
Collaborator Author

@jamesricky the icons look off. This is probably fixed with #2919, right?

@jamesricky
Copy link
Contributor

jamesricky commented Feb 5, 2025

@jamesricky the icons look off. This is probably fixed with #2919, right?

No that's a different issue, should be fixed with https://vivid-planet.atlassian.net/browse/COM-1598

The problem is that MuiSelect-input doesn't support any content other than text by default.

@johnnyomair
Copy link
Collaborator Author

The problem is that MuiSelect-input doesn't support any content other than text by default.

I meant in the list. But you're right, we'll have to fix it in the input as well.

@jamesricky
Copy link
Contributor

The problem is that MuiSelect-input doesn't support any content other than text by default.

I meant in the list. But you're right, we'll have to fix it in the input as well.

Ah yes, the icon in the list will be fixed with the PR you mentioned.

@johnnyomair johnnyomair merged commit 0feb568 into main Feb 19, 2025
11 checks passed
@johnnyomair johnnyomair deleted the docs-createCompositeBlockSelectField branch February 19, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants