Skip to content

Commit

Permalink
Merge branch 'next' into refactor-menu-styling
Browse files Browse the repository at this point in the history
  • Loading branch information
juliawegmayr committed Jan 21, 2025
2 parents f5ee69f + 95bea5c commit cf40074
Show file tree
Hide file tree
Showing 1,023 changed files with 24,733 additions and 19,084 deletions.
6 changes: 6 additions & 0 deletions .changeset/blue-flies-compete.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@comet/cms-admin": patch
"@comet/cms-api": patch
---

Fix page tree node slug validation to prevent URL encoded characters
7 changes: 7 additions & 0 deletions .changeset/calm-clocks-switch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@comet/cms-api": patch
---

Migrate from deprecated `@azure/openai` package to `openai`

See https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/migration-javascript for more information.
7 changes: 7 additions & 0 deletions .changeset/chatty-pets-serve.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@comet/cms-api": major
---

Add `class-transformer`, `reflect-metadata`, and `rxjs` as peer dependencies

To upgrade, install the latest versions of the packages in your project.
5 changes: 5 additions & 0 deletions .changeset/clean-dots-pull.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-api": patch
---

Add `BlocksBlockInputInterface` to the public API
39 changes: 39 additions & 0 deletions .changeset/cyan-ghosts-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
"@comet/admin-theme": major
---

Prevent the selection of DataGrid rows by clicking on them

According to the Comet design guidelines, rows should be selected using checkboxes, with the `checkboxSelection` prop, where required.

```tsx
<DataGrid
checkboxSelection
onRowSelectionModelChange={(newRowSelectionModel) => {
setRowSelectionModel(newRowSelectionModel);
}}
rowSelectionModel={rowSelectionModel}
// ...
/>
```

To restore the previous behavior, set the `disableRowSelectionOnClick` prop to `false` in the individual `DataGrid` component or globally, using the theme's `defaultProps`.

```tsx
<DataGrid
disableRowSelectionOnClick
// ...
/>
```

```tsx
const theme = createCometTheme({
components: {
MuiDataGrid: {
defaultProps: {
disableRowSelectionOnClick: false,
},
},
},
});
```
5 changes: 5 additions & 0 deletions .changeset/cyan-shoes-beg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": minor
---

Hide group title in `CrudMoreActionsMenu` when only one group is present
7 changes: 7 additions & 0 deletions .changeset/dirty-brooms-beam.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@comet/cms-api": major
---

Bump MikroORM peer dependency to v6

Follow the official [migration guide](https://mikro-orm.io/docs/upgrading-v5-to-v6) to upgrade.
5 changes: 5 additions & 0 deletions .changeset/eighty-cheetahs-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-admin": patch
---

Hide the "Dependents" tab in the DAM for users without the permission `dependencies`
5 changes: 5 additions & 0 deletions .changeset/eighty-zebras-rescue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin-theme": patch
---

Adapt styling of `DialogActions`, `DialogContent`, and `DialogTitle` to match the Comet DXP design
21 changes: 21 additions & 0 deletions .changeset/fifty-buses-hope.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
"@comet/admin": major
---

Adapt the styling of `Alert` to match the updated Comet design

Remove styling for the `text` variant of buttons used in `Alert`.
Use buttons with the `outlined` variant instead to adhere to the Comet design guidelines.

```diff
<Alert
// ...
action={
- <Button variant="text" startIcon={<ArrowRight />}>
+ <Button variant="outlined" startIcon={<ArrowRight />}>
Action Text
</Button>
}
// ...
>
```
16 changes: 16 additions & 0 deletions .changeset/five-wolves-kneel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
"@comet/blocks-admin": minor
---

Simplify setting field props when using `createCompositeBlockTextField` or `createCompositeBlockSelectField`

The props can now be set directly without nesting them inside the `fieldProps` object.

```diff
block: createCompositeBlockTextField({
- fieldProps: {
label: "Title",
fullWidth: true,
- },
}),
```
5 changes: 5 additions & 0 deletions .changeset/four-forks-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin-date-time": patch
---

Add `DatePickerNavigationClassKey`, `DatePickerNavigationProps`, `DateTimePickerClassKey`, `FinalFormTimePickerProps`, `TimePickerClassKey`, and `TimeRangePickerClassKey` to the public API
5 changes: 5 additions & 0 deletions .changeset/four-weeks-tan.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": patch
---

Fix mobile styling of `AppHeaderMenuButton`
28 changes: 14 additions & 14 deletions .changeset/giant-teachers-tease.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ Therefore, the `@comet/blocks-api` is merged into this package.

**Breaking changes**

- The `@comet/blocks-api` package doesn't exist anymore
- The `getFieldKeys` function has been removed from the public API
- Multiple exports that were too generic have been renamed
- `getMostSignificantPreviewImageUrlTemplate` -> `getMostSignificantPreviewImageUrlTemplateFromBlock`
- `getPreviewImageUrlTemplates` -> `getPreviewImageUrlTemplatesFromBlock`
- `getSearchText` -> `getSearchTextFromBlock`
- `inputToData` -> `blockInputToData`
- `TransformResponse` -> `TransformBlockResponse`
- `TransformResponseArray` -> `TransformBlockResponseArray`
- `transformToSave` -> `transformToBlockSave`
- `transformToSaveIndex` -> `transformToBlockSaveIndex`
- `TraversableTransformResponse` -> `TraversableTransformBlockResponse`
- `TraversableTransformResponseArray` -> `TraversableTransformBlockResponseArray`
- `typesafeMigrationPipe` -> `typeSafeBlockMigrationPipe`
- The `@comet/blocks-api` package doesn't exist anymore
- The `getFieldKeys` function has been removed from the public API
- Multiple exports that were too generic have been renamed
- `getMostSignificantPreviewImageUrlTemplate` -> `getMostSignificantPreviewImageUrlTemplateFromBlock`
- `getPreviewImageUrlTemplates` -> `getPreviewImageUrlTemplatesFromBlock`
- `getSearchText` -> `getSearchTextFromBlock`
- `inputToData` -> `blockInputToData`
- `TransformResponse` -> `TransformBlockResponse`
- `TransformResponseArray` -> `TransformBlockResponseArray`
- `transformToSave` -> `transformToBlockSave`
- `transformToSaveIndex` -> `transformToBlockSaveIndex`
- `TraversableTransformResponse` -> `TraversableTransformBlockResponse`
- `TraversableTransformResponseArray` -> `TraversableTransformBlockResponseArray`
- `typesafeMigrationPipe` -> `typeSafeBlockMigrationPipe`

**How to upgrade**

Expand Down
7 changes: 7 additions & 0 deletions .changeset/gold-snails-dream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@comet/admin": minor
---

Add a new `FillSpace` component to replace `ToolbarFillSpace` and `AppHeaderFillSpace`

`ToolbarFillSpace` and `AppHeaderFillSpace` are now deprecated.
5 changes: 5 additions & 0 deletions .changeset/happy-onions-rest.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": minor
---

Deprecate `FinalFormRadio` and `FinalFormCheckbox`
5 changes: 5 additions & 0 deletions .changeset/heavy-drinks-leave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-api": patch
---

Pass `x-preview-dam-urls` and `x-relative-dam-urls` headers to `url` field resolver in `FileImagesResolver`
8 changes: 8 additions & 0 deletions .changeset/hip-seahorses-wash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@comet/cms-admin": minor
"@comet/cms-api": minor
---

Validate filename length for uploads to DAM or FileUploads

The filename can't exceed 255 characters.
5 changes: 5 additions & 0 deletions .changeset/honest-bananas-shout.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": minor
---

Export `renderFinalFormChildren` helper
15 changes: 15 additions & 0 deletions .changeset/hot-cheetahs-juggle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"@comet/cms-admin": patch
"@comet/cms-api": patch
---

Remove `video/avi`, `image/psd` and `video/x-m4v` from default accepted mimetypes

None of this mimetypes had an actual impact:

- `video/avi` doesn't actually exist
- `image/psd` doesn't exist / is non-standard
- `video/x-m4v` is a niche format and the mimetype is not widely used (e.g., Google Chrome and MacOS use `video/mp4`
instead)

So removing them shouldn't have any noticeable effects.
9 changes: 9 additions & 0 deletions .changeset/hungry-ties-relate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@comet/cms-admin": patch
"@comet/cms-api": patch
---

Add `image/x-icon` to default accepted mimetypes

Previously, only `image/vnd.microsoft.icon` was supported. That could lead to problems uploading .ico files, since
`image/vnd.microsoft.icon` and `image/x-icon` are valid mimetypes for this format.
5 changes: 5 additions & 0 deletions .changeset/khaki-zebras-roll.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-site": patch
---

Add `AdminMessageType`, `IAdminContentScopeMessage`, `IAdminGraphQLApiUrlMessage`, `IAdminHoverComponentMessage`, `IAdminShowOnlyVisibleMessage`, `IFrameHoverComponentMessage`, `IFrameLocationMessage`, `IFrameMessage`, `IFrameMessageType`, `IFrameOpenLinkMessage`, `IFrameSelectComponentMessage`, and `IReadyIFrameMessage` to the public API
5 changes: 5 additions & 0 deletions .changeset/large-apples-learn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin-theme": minor
---

Add styling of `Card` and `CardHeader` to align with Comet DXP design
5 changes: 5 additions & 0 deletions .changeset/lucky-books-thank.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin-color-picker": patch
---

Add `ColorPickerNoColorPreviewProps` to the public API
8 changes: 8 additions & 0 deletions .changeset/lucky-doors-raise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@comet/eslint-config": major
---

Prevent `@mui/material` tooltip imports

Tooltips used in Comet DXP applications should match the Comet CI.
Use tooltips from `@comet/admin` instead.
7 changes: 7 additions & 0 deletions .changeset/mean-pears-tie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@comet/cms-admin": patch
---

Export `useDamScope` hook

This allows accessing the DAM scope in the application. This might be necessary when developing integrations with a third-party DAM.
5 changes: 5 additions & 0 deletions .changeset/mighty-vans-speak.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/blocks-admin": patch
---

Allow passing a function as child to `BlocksFinalForm`
5 changes: 5 additions & 0 deletions .changeset/nasty-pets-check.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/eslint-config": major
---

Bump Prettier peer dependency to v3
7 changes: 7 additions & 0 deletions .changeset/nervous-actors-do.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@comet/cms-api": major
---

Add `@mikro-orm/cli` as peer dependency

To upgrade, install `@mikro-orm/cli` v6.0.0 or later.
5 changes: 5 additions & 0 deletions .changeset/new-cherries-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-api": patch
---

Fix input validation for missing child blocks
8 changes: 8 additions & 0 deletions .changeset/nice-bananas-press.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@comet/eslint-config": major
---

Enable rule to restrict barrel React imports

Importing `React` is no longer necessary due to the new JSX transform, which automatically imports the necessary `react/jsx-runtime` functions.
Use individual named imports instead, e.g, `import { useState } from "react"`.
1 change: 0 additions & 1 deletion .changeset/perfect-mangos-greet.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
"@comet/admin-color-picker": major
"@comet/admin-react-select": major
"@comet/admin-date-time": major
"@comet/blocks-admin": major
"@comet/admin-icons": major
Expand Down
5 changes: 5 additions & 0 deletions .changeset/rude-moons-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": patch
---

Adjust the spacings inside `Toolbar` and `DataGridToolbar` to match the Comet design
5 changes: 5 additions & 0 deletions .changeset/sharp-apes-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": patch
---

Add `AppHeaderFillSpaceProps`, `ClearInputAdornmentClassKey`, `ToolbarActionButtonClassKey`, `ToolbarActionButton`, `CrudMoreActionsMenuClassKey`, `GridActionsColDef`, `GridBaseColDef`, `GridSingleSelectColDef`, and `TableDndOrderClassKey` to the public API
5 changes: 5 additions & 0 deletions .changeset/sharp-dryers-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": patch
---

Allow non-full-width fields in `FieldSet`
7 changes: 7 additions & 0 deletions .changeset/short-singers-trade.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@comet/blocks-admin": minor
---

Add `createCompositeBlockSwitchField` helper function

To simplify the creation of a switch field block by hiding the verbose definition of `Form`, `Field` and items.
5 changes: 5 additions & 0 deletions .changeset/smart-humans-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-api": patch
---

Prevent image uploads from failing if exif data cannot be parsed
5 changes: 5 additions & 0 deletions .changeset/smooth-shrimps-exist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cli": minor
---

Add option for base64 encoding in `inject-site-configs` command
5 changes: 5 additions & 0 deletions .changeset/spicy-bottles-admire.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-site": patch
---

Add `AdminMessageType`, `IAdminContentScopeMessage`, `IAdminGraphQLApiUrlMessage`, `IAdminHoverComponentMessage`, `IAdminShowOnlyVisibleMessage`, `IFrameHoverComponentMessage`, `IFrameLocationMessage`, `IFrameMessage`, `IFrameMessageType`, `IFrameOpenLinkMessage`, `IFrameSelectComponentMessage`, and `IReadyIFrameMessage` to the public API
8 changes: 8 additions & 0 deletions .changeset/spotty-stingrays-camp.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@comet/cms-admin": patch
---

Update default icon of `ContentScopeSelect` and fix mobile styling for `AppHeader` components

- Update the default icon in `ContentScopeSelect` from `<Domain />` to `<Language />`
- Fix mobile styling of `BuildEntry` and `ContentScopeSelect` and `UserHeaderItem`
5 changes: 5 additions & 0 deletions .changeset/sweet-ways-relax.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/admin": major
---

Remove `trigger` prop from `Tooltip`
18 changes: 18 additions & 0 deletions .changeset/tasty-news-change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
"@comet/cms-api": minor
---

Add `ExceptionFilter` to replace `ExceptionInterceptor`

The main motivation for this change was that the `ExceptionInterceptor` didn't capture exceptions thrown in guards. This could lead to information leaks, e.g., details about the database schema or the underlying code. This is considered a security risk.

The `ExceptionFilter` also catches error within guards. The error format remains unchanged.

Switching from the `ExceptionInterceptor` to the `ExceptionFilter` must be done in the project:

```diff
// main.ts

- app.useGlobalInterceptors(new ExceptionInterceptor(config.debug));
+ app.useGlobalFilters(new ExceptionFilter(config.debug));
```
Loading

0 comments on commit cf40074

Please sign in to comment.