-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'next' into refactor-menu-styling
- Loading branch information
Showing
1,023 changed files
with
24,733 additions
and
19,084 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@comet/cms-admin": patch | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Fix page tree node slug validation to prevent URL encoded characters |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Migrate from deprecated `@azure/openai` package to `openai` | ||
|
||
See https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/migration-javascript for more information. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/cms-api": major | ||
--- | ||
|
||
Add `class-transformer`, `reflect-metadata`, and `rxjs` as peer dependencies | ||
|
||
To upgrade, install the latest versions of the packages in your project. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Add `BlocksBlockInputInterface` to the public API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
--- | ||
"@comet/admin-theme": major | ||
--- | ||
|
||
Prevent the selection of DataGrid rows by clicking on them | ||
|
||
According to the Comet design guidelines, rows should be selected using checkboxes, with the `checkboxSelection` prop, where required. | ||
|
||
```tsx | ||
<DataGrid | ||
checkboxSelection | ||
onRowSelectionModelChange={(newRowSelectionModel) => { | ||
setRowSelectionModel(newRowSelectionModel); | ||
}} | ||
rowSelectionModel={rowSelectionModel} | ||
// ... | ||
/> | ||
``` | ||
|
||
To restore the previous behavior, set the `disableRowSelectionOnClick` prop to `false` in the individual `DataGrid` component or globally, using the theme's `defaultProps`. | ||
|
||
```tsx | ||
<DataGrid | ||
disableRowSelectionOnClick | ||
// ... | ||
/> | ||
``` | ||
|
||
```tsx | ||
const theme = createCometTheme({ | ||
components: { | ||
MuiDataGrid: { | ||
defaultProps: { | ||
disableRowSelectionOnClick: false, | ||
}, | ||
}, | ||
}, | ||
}); | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": minor | ||
--- | ||
|
||
Hide group title in `CrudMoreActionsMenu` when only one group is present |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/cms-api": major | ||
--- | ||
|
||
Bump MikroORM peer dependency to v6 | ||
|
||
Follow the official [migration guide](https://mikro-orm.io/docs/upgrading-v5-to-v6) to upgrade. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cms-admin": patch | ||
--- | ||
|
||
Hide the "Dependents" tab in the DAM for users without the permission `dependencies` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin-theme": patch | ||
--- | ||
|
||
Adapt styling of `DialogActions`, `DialogContent`, and `DialogTitle` to match the Comet DXP design |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
"@comet/admin": major | ||
--- | ||
|
||
Adapt the styling of `Alert` to match the updated Comet design | ||
|
||
Remove styling for the `text` variant of buttons used in `Alert`. | ||
Use buttons with the `outlined` variant instead to adhere to the Comet design guidelines. | ||
|
||
```diff | ||
<Alert | ||
// ... | ||
action={ | ||
- <Button variant="text" startIcon={<ArrowRight />}> | ||
+ <Button variant="outlined" startIcon={<ArrowRight />}> | ||
Action Text | ||
</Button> | ||
} | ||
// ... | ||
> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
"@comet/blocks-admin": minor | ||
--- | ||
|
||
Simplify setting field props when using `createCompositeBlockTextField` or `createCompositeBlockSelectField` | ||
|
||
The props can now be set directly without nesting them inside the `fieldProps` object. | ||
|
||
```diff | ||
block: createCompositeBlockTextField({ | ||
- fieldProps: { | ||
label: "Title", | ||
fullWidth: true, | ||
- }, | ||
}), | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin-date-time": patch | ||
--- | ||
|
||
Add `DatePickerNavigationClassKey`, `DatePickerNavigationProps`, `DateTimePickerClassKey`, `FinalFormTimePickerProps`, `TimePickerClassKey`, and `TimeRangePickerClassKey` to the public API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": patch | ||
--- | ||
|
||
Fix mobile styling of `AppHeaderMenuButton` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/admin": minor | ||
--- | ||
|
||
Add a new `FillSpace` component to replace `ToolbarFillSpace` and `AppHeaderFillSpace` | ||
|
||
`ToolbarFillSpace` and `AppHeaderFillSpace` are now deprecated. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": minor | ||
--- | ||
|
||
Deprecate `FinalFormRadio` and `FinalFormCheckbox` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Pass `x-preview-dam-urls` and `x-relative-dam-urls` headers to `url` field resolver in `FileImagesResolver` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@comet/cms-admin": minor | ||
"@comet/cms-api": minor | ||
--- | ||
|
||
Validate filename length for uploads to DAM or FileUploads | ||
|
||
The filename can't exceed 255 characters. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": minor | ||
--- | ||
|
||
Export `renderFinalFormChildren` helper |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
"@comet/cms-admin": patch | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Remove `video/avi`, `image/psd` and `video/x-m4v` from default accepted mimetypes | ||
|
||
None of this mimetypes had an actual impact: | ||
|
||
- `video/avi` doesn't actually exist | ||
- `image/psd` doesn't exist / is non-standard | ||
- `video/x-m4v` is a niche format and the mimetype is not widely used (e.g., Google Chrome and MacOS use `video/mp4` | ||
instead) | ||
|
||
So removing them shouldn't have any noticeable effects. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
"@comet/cms-admin": patch | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Add `image/x-icon` to default accepted mimetypes | ||
|
||
Previously, only `image/vnd.microsoft.icon` was supported. That could lead to problems uploading .ico files, since | ||
`image/vnd.microsoft.icon` and `image/x-icon` are valid mimetypes for this format. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cms-site": patch | ||
--- | ||
|
||
Add `AdminMessageType`, `IAdminContentScopeMessage`, `IAdminGraphQLApiUrlMessage`, `IAdminHoverComponentMessage`, `IAdminShowOnlyVisibleMessage`, `IFrameHoverComponentMessage`, `IFrameLocationMessage`, `IFrameMessage`, `IFrameMessageType`, `IFrameOpenLinkMessage`, `IFrameSelectComponentMessage`, and `IReadyIFrameMessage` to the public API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin-theme": minor | ||
--- | ||
|
||
Add styling of `Card` and `CardHeader` to align with Comet DXP design |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin-color-picker": patch | ||
--- | ||
|
||
Add `ColorPickerNoColorPreviewProps` to the public API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@comet/eslint-config": major | ||
--- | ||
|
||
Prevent `@mui/material` tooltip imports | ||
|
||
Tooltips used in Comet DXP applications should match the Comet CI. | ||
Use tooltips from `@comet/admin` instead. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/cms-admin": patch | ||
--- | ||
|
||
Export `useDamScope` hook | ||
|
||
This allows accessing the DAM scope in the application. This might be necessary when developing integrations with a third-party DAM. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/blocks-admin": patch | ||
--- | ||
|
||
Allow passing a function as child to `BlocksFinalForm` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/eslint-config": major | ||
--- | ||
|
||
Bump Prettier peer dependency to v3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/cms-api": major | ||
--- | ||
|
||
Add `@mikro-orm/cli` as peer dependency | ||
|
||
To upgrade, install `@mikro-orm/cli` v6.0.0 or later. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Fix input validation for missing child blocks |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@comet/eslint-config": major | ||
--- | ||
|
||
Enable rule to restrict barrel React imports | ||
|
||
Importing `React` is no longer necessary due to the new JSX transform, which automatically imports the necessary `react/jsx-runtime` functions. | ||
Use individual named imports instead, e.g, `import { useState } from "react"`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": patch | ||
--- | ||
|
||
Adjust the spacings inside `Toolbar` and `DataGridToolbar` to match the Comet design |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": patch | ||
--- | ||
|
||
Add `AppHeaderFillSpaceProps`, `ClearInputAdornmentClassKey`, `ToolbarActionButtonClassKey`, `ToolbarActionButton`, `CrudMoreActionsMenuClassKey`, `GridActionsColDef`, `GridBaseColDef`, `GridSingleSelectColDef`, and `TableDndOrderClassKey` to the public API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": patch | ||
--- | ||
|
||
Allow non-full-width fields in `FieldSet` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/blocks-admin": minor | ||
--- | ||
|
||
Add `createCompositeBlockSwitchField` helper function | ||
|
||
To simplify the creation of a switch field block by hiding the verbose definition of `Form`, `Field` and items. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cms-api": patch | ||
--- | ||
|
||
Prevent image uploads from failing if exif data cannot be parsed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cli": minor | ||
--- | ||
|
||
Add option for base64 encoding in `inject-site-configs` command |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/cms-site": patch | ||
--- | ||
|
||
Add `AdminMessageType`, `IAdminContentScopeMessage`, `IAdminGraphQLApiUrlMessage`, `IAdminHoverComponentMessage`, `IAdminShowOnlyVisibleMessage`, `IFrameHoverComponentMessage`, `IFrameLocationMessage`, `IFrameMessage`, `IFrameMessageType`, `IFrameOpenLinkMessage`, `IFrameSelectComponentMessage`, and `IReadyIFrameMessage` to the public API |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@comet/cms-admin": patch | ||
--- | ||
|
||
Update default icon of `ContentScopeSelect` and fix mobile styling for `AppHeader` components | ||
|
||
- Update the default icon in `ContentScopeSelect` from `<Domain />` to `<Language />` | ||
- Fix mobile styling of `BuildEntry` and `ContentScopeSelect` and `UserHeaderItem` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@comet/admin": major | ||
--- | ||
|
||
Remove `trigger` prop from `Tooltip` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
"@comet/cms-api": minor | ||
--- | ||
|
||
Add `ExceptionFilter` to replace `ExceptionInterceptor` | ||
|
||
The main motivation for this change was that the `ExceptionInterceptor` didn't capture exceptions thrown in guards. This could lead to information leaks, e.g., details about the database schema or the underlying code. This is considered a security risk. | ||
|
||
The `ExceptionFilter` also catches error within guards. The error format remains unchanged. | ||
|
||
Switching from the `ExceptionInterceptor` to the `ExceptionFilter` must be done in the project: | ||
|
||
```diff | ||
// main.ts | ||
|
||
- app.useGlobalInterceptors(new ExceptionInterceptor(config.debug)); | ||
+ app.useGlobalFilters(new ExceptionFilter(config.debug)); | ||
``` |
Oops, something went wrong.