-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spacing for ListItemIcon
and ListItemAvatar
#3416
Conversation
2f74841
to
5fd1ebe
Compare
@jamesricky @johnnyomair I know, that Ricky suggested to move the styling from MenuItem to ListItemIcon to avoid different styles (here: #2919 (comment)). But as far as I can tell, we need them to be different at the moment (see screenshots). 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the text in the content scope select really have that much spacing on the left? Is it like this in the design?
packages/admin/admin-theme/src/componentsTheme/getComponentsTheme.ts
Outdated
Show resolved
Hide resolved
MuiListItemIcon
in MuiMenuItem
8ce978c
to
4edeb10
Compare
No it shouldn't. Thank you for the hint. I checked the design and the usage of ListItemIcon again and I found out that my assumption was wrong and that all ListItemIcons are styled incorrectly. A better solution for fixing the ListItemIcon to match the design is to add a gap. I reverted my changes, and also adapted the description of this PR with updated screenshots. (Thank you @jamesricky for the idea with the gap :) ) |
MuiListItemIcon
in MuiMenuItem
ListItemIcon
and ListItemAvatar
packages/admin/admin-theme/src/componentsTheme/MuiListItemAvatar.tsx
Outdated
Show resolved
Hide resolved
packages/admin/admin-theme/src/componentsTheme/MuiListItemAvatar.tsx
Outdated
Show resolved
Hide resolved
ff72249
to
3e0a64a
Compare
Description
Refactoring the Menu styling (#3346) caused bugs in the styling of ListItemIcons. Add a gap to match the design.
Acceptance criteria
Screenshots/screencasts
Open TODOs/questions
Further information