COM-85: Allow extending slots from Admin components #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
johnnyomair
reviewed
Nov 28, 2023
4d1ddf3 to
1c6694d
Compare
johnnyomair
previously approved these changes
Nov 28, 2023
thomasdax98
reviewed
Nov 28, 2023
Extending a Comet Admin component using `styled()` requires the `className` prop to be passed through to the components `root` slot. Also added the `ThemedComponentBaseProps` type to use as a base for components props. This abstracts away the need to manually define the `sx`, `className` and `slotProps` props in every component.
1c6694d to
515f868
Compare
thomasdax98
approved these changes
Nov 28, 2023
johnnyomair
approved these changes
Nov 28, 2023
jamesricky
added a commit
that referenced
this pull request
Jan 9, 2024
Extending a Comet Admin component using `styled()` requires the `className` prop to be passed through to the components `root` slot. Also added the `ThemedComponentBaseProps` type to use as a base for components props. This abstracts away the need to manually define the `sx`, `className` and `slotProps` props in every component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending a Comet Admin component using
styled()requires theclassNameprop to be passed through to the componentsrootslot.Also added the
ThemedComponentBasePropstype to use as a base for components props.This abstracts away the need to manually define the
sx,classNameandslotPropsprops in every component.