Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COM-85: Add theming-example story from the docs #1427

Merged
merged 2 commits into from
Nov 29, 2023
Merged

COM-85: Add theming-example story from the docs #1427

merged 2 commits into from
Nov 29, 2023

Conversation

jamesricky
Copy link
Contributor

@jamesricky jamesricky commented Nov 23, 2023 •
edited
Loading

No description provided.

@jamesricky jamesricky self-assigned this Nov 23, 2023
@jamesricky jamesricky changed the title Add theming-example story from the docs COM-85: Add theming-example story from the docs Nov 23, 2023
@jamesricky jamesricky marked this pull request as draft November 27, 2023 12:12
@jamesricky jamesricky removed the request for review from johnnyomair November 27, 2023 12:12
@jamesricky jamesricky force-pushed the my-component-theming-example branch from 3b23a86 to cfadc84 Compare November 27, 2023 16:20
@jamesricky jamesricky changed the base branch from feature/refactor-admin-component-theming to allow-slots-to-extend-admin-components November 27, 2023 16:20
@jamesricky jamesricky marked this pull request as ready for review November 27, 2023 16:20
@jamesricky jamesricky force-pushed the allow-slots-to-extend-admin-components branch 2 times, most recently from 1c6694d to 515f868 Compare November 28, 2023 14:24
Base automatically changed from allow-slots-to-extend-admin-components to feature/refactor-admin-component-theming November 28, 2023 14:37
@jamesricky jamesricky force-pushed the my-component-theming-example branch from cfadc84 to 2e5cc24 Compare November 29, 2023 07:30
johnnyomair
johnnyomair reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decide to create the working example in Storybook, and not in Docusaurus? We have a POC for a Story (including live-editing): https://docs.comet-dxp.com/docs/story-poc/

@jamesricky
Copy link
Contributor Author

Why did you decide to create the working example in Storybook, and not in Docusaurus? We have a POC for a Story (including live-editing): https://docs.comet-dxp.com/docs/story-poc/

I mainly added this so I have something I can use for testing/debugging the theming functionality.
This is more of a Dev-Story, so not really relevant for the Docs imo.

@jamesricky jamesricky merged commit 74c36fa into feature/refactor-admin-component-theming Nov 29, 2023
@jamesricky jamesricky deleted the my-component-theming-example branch November 29, 2023 09:51
jamesricky added a commit that referenced this pull request Jan 9, 2024
@jamesricky
COM-85: Add theming-example story from the docs (#1427)
9bb831b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jamesricky jamesricky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesricky @johnnyomair