COM-85: Refactor theming of ErrorBoundary #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c6694d to
515f868
Compare
Base automatically changed from
allow-slots-to-extend-admin-components
to
feature/refactor-admin-component-theming
November 28, 2023 14:37
8b8b224 to
89dda01
Compare
Refactoring to a function-component is not possible, as there is no alternative to `componentDidCatch`, according to the [React Docs](https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary): > There is currently no way to write an error boundary as a function component.
89dda01 to
ec3d9f2
Compare
johnnyomair
reviewed
Nov 29, 2023
johnnyomair
approved these changes
Nov 29, 2023
jamesricky
added a commit
that referenced
this pull request
Jan 9, 2024
Refactoring to a function-component is not possible, as there is no alternative to `componentDidCatch`, according to the [React Docs](https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary): > There is currently no way to write an error boundary as a function component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to a function-component is not possible, as there is no alternative to
componentDidCatch,according to the React Docs: