COM-85: Refactor Tooltip theming #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f8ac10 to
7287c1e
Compare
7287c1e to
b9e9c2d
Compare
b9e9c2d to
138c6af
Compare
1c6694d to
515f868
Compare
Base automatically changed from
allow-slots-to-extend-admin-components
to
feature/refactor-admin-component-theming
November 28, 2023 14:37
Copying the styling and `overridesResolver` from MUIs TooltipPopper is required because when overriding the Tooltips Popper we cannot extend the existing Popper. Overriding the Popper is required to implement our variant-specific styling, as we cannot set the styles from the Root element, as the Popper is not rendered as a child of the Tooltip in the DOM.
138c6af to
386b5a5
Compare
johnnyomair
approved these changes
Nov 29, 2023
jamesricky
added a commit
that referenced
this pull request
Jan 9, 2024
Copying the styling and `overridesResolver` from MUIs TooltipPopper is required because when overriding the Tooltips Popper we cannot extend the existing Popper. Overriding the Popper is required to implement our variant-specific styling, as we cannot set the styles from the Root element, as the Popper is not rendered as a child of the Tooltip in the DOM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the styling and
overridesResolverfrom MUIs TooltipPopper is required because when overriding the Tooltips Popper we cannot extend the existing Popper.Overriding the Popper is required to implement our variant-specific styling, as we cannot set the styles from the Root element, as the Popper is not rendered as a child of the Tooltip in the DOM.