-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React from c3048aab4 to cb151849e1 #64994
Conversation
Would be nice to do this via onCaughtError but I copying the full impl of `defaultOnCaughtError` seems sketchy. See https://vercel.slack.com/archives/C04TR3U872A/p1713969391445789 for quick proposal
Fixes displaying 2 errors in the redbox when just one was thrown. It counted 2 because we had the actual error and React's "the above occured"
`next/dist/compiled/react-dom` can never appear in a require call i.e. be treated as an external because these modules don't import from vendored react-dom but installed react-dom
Failing test suitesCommit: ccb01f5
Expand output● app dir - with output export and custom distDir (next dev) › should render properly
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - css with pageextensions › css support with pageextensions › page in app directory with pageextention, css should work › should support global css inside layout
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - crossOrigin config › skip in start mode
Read more about building and testing Next.js in contributing.md.
Expand output● app-dynamic-error › production mode › throws an error when prerendering a page with config dynamic error
Read more about building and testing Next.js in contributing.md.
Expand output● build trace with extra entries › production mode › should build and trace correctly
Read more about building and testing Next.js in contributing.md.
Expand output● hmr-deleted-page › should not show errors for a deleted page
Read more about building and testing Next.js in contributing.md.
Expand output● custom-app-server-action-redirect › redirects with basepath properly when server action handler uses
● custom-app-server-action-redirect › redirects with proper cookies set from both redirect response and post respose
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir action disallowed origins › should error if x-forwarded-host does not match the origin
Read more about building and testing Next.js in contributing.md.
Expand output● babel-next-image › should work with babel and next/image
Read more about building and testing Next.js in contributing.md.
Expand output● App assetPrefix config › should render correctly with assetPrefix: "/"
Read more about building and testing Next.js in contributing.md.
Expand output● app-prefetch-static › should correctly navigate between static & dynamic pages
Read more about building and testing Next.js in contributing.md.
Expand output● _allow-underscored-root-directory › should not serve app path with underscore
● _allow-underscored-root-directory › should pages path with a underscore at the root
● _allow-underscored-root-directory › should serve app path with %5F
Read more about building and testing Next.js in contributing.md.
Expand output● dynamic = "error" in devmode › should show error overlay when dynamic is forced
Read more about building and testing Next.js in contributing.md.
Expand output● ReactRefresh app › can edit a component without losing state
● ReactRefresh app › cyclic dependencies
Read more about building and testing Next.js in contributing.md.
Expand output● build trace with extra entries › production mode › should build and trace correctly
Read more about building and testing Next.js in contributing.md.
Expand output● app-simple-routes › works with simple routes › renders a node route
● app-simple-routes › works with simple routes › renders a edge route
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - with output export (next dev / next build) › production mode › should error when running next export
Read more about building and testing Next.js in contributing.md.
Expand output● app-routes-trailing-slash › should handle trailing slash for edge runtime
● app-routes-trailing-slash › should handle trailing slash for node runtime
Read more about building and testing Next.js in contributing.md.
Expand output● app dir › Loading › should render loading.js in initial html for slow page
Read more about building and testing Next.js in contributing.md.
Expand output● app dir rendering › should serve app/page.server.js at /
● app dir rendering › SSR only › should run data in layout and page
● app dir rendering › SSR only › should run data fetch in parallel
● app dir rendering › static only › should run data in layout and page
● app dir rendering › static only › should run data in parallel and use cached version for production
● app dir rendering › ISR › should revalidate the page when revalidate is configured
● app dir rendering › mixed static and dynamic › should generate static data during build and use it
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir action allowed origins › should pass if localhost is set as a safe origin
Read more about building and testing Next.js in contributing.md.
Expand output● ReactRefreshRequire app › re-runs accepted modules
● ReactRefreshRequire app › propagates a hot update to closest accepted module
● ReactRefreshRequire app › propagates hot update to all inverse dependencies
Read more about building and testing Next.js in contributing.md.
Expand output● Image Component from node_modules development mode › should apply image config for node_modules
Read more about building and testing Next.js in contributing.md.
Expand output● build with proxy trace › production mode › should build and output trace correctly
Read more about building and testing Next.js in contributing.md.
Expand output● Static Image Component Tests › development mode › Should allow an image with a static src to omit height and width
● Static Image Component Tests › development mode › should have containing followed by for priority image
● Static Image Component Tests › development mode › Should automatically provide an image height and width
● Static Image Component Tests › development mode › should use width and height prop to override import
● Static Image Component Tests › development mode › should use height prop to adjust both width and height
● Static Image Component Tests › development mode › should use width prop to adjust both width and height
● Static Image Component Tests › development mode › should add a data URL placeholder to an image
● Static Image Component Tests › development mode › should add a blur placeholder a statically imported jpg
● Static Image Component Tests › development mode › should add a blur placeholder a statically imported png
● Static Image Component Tests › development mode › should add a blur placeholder a statically imported png with fill
● Static Image Component Tests › development mode › should add placeholder with blurDataURL and fill
● Static Image Component Tests › development mode › should add placeholder even when blurDataURL aspect ratio does not match width/height ratio
● Static Image Component Tests › development mode › should load direct imported image
Read more about building and testing Next.js in contributing.md. |
Continued in #65058 |
React upstream changes
react-dom/client
facebook/react#28271cache
instrumentation facebook/react#28896replayFailedUnitOfWorkWithInvokeGuardedCallback
andenableProfilerNestedUpdateScheduledHook
facebook/react#28891renderToStaticNodeStream
facebook/react#28873renderToStaticNodeStream
facebook/react#28872flight-browser
fixture facebook/react#28828assertConsole<method>Dev
helpers facebook/react#28732<noscript>
facebook/react#28815__CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE
facebook/react#28789props.async
in Float consistent with the rest of react-dom facebook/react#26760flushSync
out of the reconciler facebook/react#28500createModelResolver
facebook/react#28669Module
facebook/react#28678findDOMNode
from OSS builds facebook/react#28267act
fromreact-dom/test-utils
in favor of act fromreact
facebook/react#28597act()
facebook/react#28541alwaysThrottleDisappearingFallbacks
Flag facebook/react#28639Module
facebook/react#28678findDOMNode
from OSS builds facebook/react#28267act
fromreact-dom/test-utils
in favor of act fromreact
facebook/react#28597act()
facebook/react#28541alwaysThrottleDisappearingFallbacks
Flag facebook/react#28639Closes NEXT-3218