Remove automatic fetch cache instrumentation
#28896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the automatic patching of the global `fetch` function in Server Components environments to dedupe requests using `React.cache`, a behavior that some RSC framework maintainers have objected to. We may revisit this decision in the future, but for now it's not worth the controversy. Frameworks that have already shipped this behavior, like Next.js, can reimplement it in userspace. I considered keeping the implementation in the codebase and disabling it by setting `enableFetchInstrumentation` to `false` everywhere, but since that also disables the tests, it doesn't seem worth it because without test coverage the behavior is likely to drift regardless. We can just revert this PR later if desired.
|
Comparing: d4e78c4...5ff57cc Critical size changesIncludes critical production bundles, as well as any change greater than 2%: Significant size changesIncludes any change greater than 0.2%: Expand to show
|
kassens
approved these changes
Apr 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
This removes the automatic patching of the global `fetch` function in Server Components environments to dedupe requests using `React.cache`, a behavior that some RSC framework maintainers have objected to. We may revisit this decision in the future, but for now it's not worth the controversy. Frameworks that have already shipped this behavior, like Next.js, can reimplement it in userspace. I considered keeping the implementation in the codebase and disabling it by setting `enableFetchInstrumentation` to `false` everywhere, but since that also disables the tests, it doesn't seem worth it because without test coverage the behavior is likely to drift regardless. We can just revert this PR later if desired. DiffTrain build for [a94838d](a94838d)
This was referenced Apr 24, 2024
This comment was marked as abuse.
This comment was marked as abuse.
|
Hello:) I think a better idea was to be that there is an option for caching. For example by default there is no caching but if the user passed in the parameter true for caching then to cache. |
|
Hi @acdlite |
|
One alternative for the future (that has most likely been considered) is for the Con: It would be slightly more verbose and potentially shadow the global when imported. Pro: App developers can opt into this behavior more explicitly and per file and it won't mess with invariants of the runtime dependent on by libraries. |
unstubbable
added a commit
to vercel/next.js
that referenced
this pull request
Aug 6, 2024
This should not be needed, now that React is not patching `fetch` anymore (see facebook/react#28896). It was previously done to fix a memory leak (see #43859). This fixes a race condition where the original `fetch` was stored before experimental test mode patched `fetch`, thus undoing the test mode `fetch` patch when resetting `fetch` during HMR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the automatic patching of the global
fetchfunction in Server Components environments to dedupe requests usingReact.cache, a behavior that some RSC framework maintainers have objected to.We may revisit this decision in the future, but for now it's not worth the controversy.
Frameworks that have already shipped this behavior, like Next.js, can reimplement it in userspace.
I considered keeping the implementation in the codebase and disabling it by setting
enableFetchInstrumentationtofalseeverywhere, but since that also disables the tests, it doesn't seem worth it because without test coverage the behavior is likely to drift regardless. We can just revert this PR later if desired.