Land enableCustomElementPropertySupport for React 19 #27450

alunyov · 2023-10-03T00:06:04Z

We've rolled out this flag internally on WWW. This PR removed flag enableCustomElementPropertySupport

Test plan:
-- yarn test

react-sizebot · 2023-10-03T00:11:27Z

Comparing: a73c345...670c7fa

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	+0.25%	176.69 kB	177.13 kB	+0.21%	54.93 kB	55.05 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.09 kB	173.09 kB	=	53.94 kB	53.94 kB
facebook-www/ReactDOM-prod.classic.js	=	592.87 kB	592.87 kB	=	104.00 kB	104.00 kB
facebook-www/ReactDOM-prod.modern.js	=	574.56 kB	574.56 kB	=	101.02 kB	101.02 kB
test_utils/ReactAllWarnings.js	Deleted	65.05 kB	0.00 kB	Deleted	16.26 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable-semver/react-dom/umd/react-dom.production.min.js	+0.25%	176.35 kB	176.79 kB	+0.24%	55.14 kB	55.28 kB
oss-stable/react-dom/umd/react-dom.production.min.js	+0.25%	176.43 kB	176.87 kB	+0.25%	55.17 kB	55.31 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js	+0.25%	176.61 kB	177.05 kB	+0.22%	54.90 kB	55.02 kB
oss-stable/react-dom/cjs/react-dom.production.min.js	+0.25%	176.69 kB	177.13 kB	+0.21%	54.93 kB	55.05 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js	+0.24%	185.38 kB	185.82 kB	+0.20%	57.53 kB	57.65 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js	+0.24%	185.46 kB	185.90 kB	+0.20%	57.56 kB	57.67 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js	+0.24%	186.08 kB	186.52 kB	+0.21%	57.26 kB	57.38 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js	+0.24%	186.16 kB	186.60 kB	+0.21%	57.29 kB	57.41 kB
test_utils/ReactAllWarnings.js	Deleted	65.05 kB	0.00 kB	Deleted	16.26 kB	0.00 kB

Generated by 🚫 dangerJS against 670c7fa

kassens · 2023-10-11T16:01:22Z

Can we just delete the flag?

alunyov · 2023-10-11T16:37:27Z

Can we just delete the flag?

Yeah, I guess we could do that.

sebmarkbage · 2023-10-12T16:34:29Z

There's a known issue with this flag here: #27286

alunyov · 2023-10-16T15:45:26Z

Rebased on top of @gnoff fix for #27286

poteto

packages/react-dom-bindings/src/client/ReactDOMComponent.js

michaelwarren1106 · 2023-12-05T15:33:08Z

just pinging this thread to see if there are any barriers to getting this merged? This PR is a clear signal of web component support in react and a lot of web components advocates are eagerly awaiting :)

gnoff · 2023-12-07T17:37:50Z

@michaelwarren1106 our plan is to include this in our next stable release which is being put together now. It will be merged closer to when we are ready to publish

klebba · 2024-01-16T21:11:47Z

@gnoff While your comment above gives me some hope, I still find myself wondering if I actually understand what to expect in the next stable release. Is there a roadmap published with the contents of the next stable release somewhere? I could not find anything myself; I have some older information about what you're working on but I don't consider everything I read to be a commitment or a comprehensive list (and support for custom element support is never mentioned).

To be honest monitoring GitHub threads (like this one) for the last several years has been frustrating and confusing. Will the React team please state plainly what to expect regarding support for custom elements in a blog post here: react.dev/blog?

As evidence that there is tremendous appetite for this content I will mention this relates to the #2 most discussed issue and the most hearted issue (it's the same) in the list of public React issues (issue locked since Oct 2023).

What I think I can expect is that the next major release will show all 32 basic & advanced tests on custom-elements-everywhere.com to be passing in an upcoming stable React release. Today this is true for React^0.0.0-experimental-3ddbedd05-20220719 which I am really happy to see. However without an announcement in an official public channel I must still hold my applause (for now).

Sorry for the rant; I do appreciate the React team's efforts! Also 👋🏻 @poteto — it's good to see a familiar face working on this :)

rickhanlonii · 2024-01-18T01:48:39Z

@klebba we're finalizing the release and then we'll be able to share what's in it. For custom elements, since this PR turns the flag on from experimental, they will ship with the PR. The main reason we're not merging this yet is because it contains breaking changes that we're not ready to land until other things in the release are ready.

klebba · 2024-01-18T18:13:57Z

Hi @rickhanlonii — thanks for your reply. I'll reiterate what I'm asking, I don't intend to be controversial and only want to know about this subject:

this PR turns the enableCustomElementPropertySupport flag on from experimental

What exactly does this flag do? What does it not do? I still hope the React team will soon state plainly what to expect regarding support for custom elements in a blog post here: react.dev/blog.

To be clear, I'm not asking:

For anything specific to be merged
For any schedule commitments to be made

I'm recommending:

Official communication about planned future support for custom elements in React
Explicit enumeration of what's in / what's out / unknown

So that I can have:

Ability to un-watch RFC: Plan for custom element attributes/properties in React 19 #11347
Ability to inform expensive forward looking business decisions regarding React
An official statement I can share with colleagues and executives
Confidence that I won't be disappointed and stuck again-again (no blame or fault intended, but I was still disappointed and stuck):

My dream would be to read a blog post on react.dev/blog along these lines:

Plan for custom elements support in next stable release

TL;DR — React 19 will now be more compatible with and have direct support for custom elements. Developers can expect that all tests on custom-elements-everywhere.com will pass by default going forward. Release date still to be announced.

Special thanks to @robdodson for championing this cause long ago!

Thanks for your time and effort!

rickhanlonii · 2024-01-18T20:14:56Z

@klebba I posted an update in #11347 (comment), we'll share updates on the blog when we share more about the next release.

klebba · 2024-01-18T20:28:29Z

Thank you @rickhanlonii — I really appreciate the clarity!

rickhanlonii · 2024-03-29T16:28:48Z

Rebased on main

We've rolled out this flag internally on WWW. This PR removed flag `enableCustomElementPropertySupport` Test plan: -- `yarn test` Co-authored-by: Ricky Hanlon <rickhanlonii@gmail.com> DiffTrain build for [eb510a3](eb510a3)

We've rolled out this flag internally on WWW. This PR removed flag `enableCustomElementPropertySupport` Test plan: -- `yarn test` Co-authored-by: Ricky Hanlon <rickhanlonii@gmail.com>

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 3, 2023

alunyov changed the title ~~[react] Set enableCustomElementPropertySupport to true~~ [react] Cleanup enableCustomElementPropertySupport flag Oct 11, 2023

alunyov requested a review from acdlite October 11, 2023 19:11

sophiebits mentioned this pull request Oct 12, 2023

RFC: Plan for custom element attributes/properties in React 19 #11347

Open

alunyov force-pushed the enableCustomElementPropertySupport branch from 4840175 to 660a689 Compare October 16, 2023 15:42

poteto approved these changes Oct 25, 2023

View reviewed changes

kassens reviewed Nov 9, 2023

View reviewed changes

packages/react-dom-bindings/src/client/ReactDOMComponent.js Show resolved Hide resolved

gnoff added the React 19 label Mar 13, 2024

rickhanlonii force-pushed the enableCustomElementPropertySupport branch from 660a689 to 7287509 Compare March 29, 2024 16:28

rickhanlonii changed the title ~~[react] Cleanup enableCustomElementPropertySupport flag~~ Land enableCustomElementPropertySupport for React 19 Mar 29, 2024

Cleanup enableCustomElementPropertySupport flag

670c7fa

rickhanlonii force-pushed the enableCustomElementPropertySupport branch from 7287509 to 670c7fa Compare March 29, 2024 16:55

rickhanlonii merged commit eb510a3 into facebook:main Mar 29, 2024
38 checks passed

eps1lon mentioned this pull request Apr 24, 2024

Update React from c3048aab4 to cb151849e1 vercel/next.js#64994

Closed

eps1lon mentioned this pull request Apr 25, 2024

Support React 19 in App and Pages router vercel/next.js#65058

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Land enableCustomElementPropertySupport for React 19 #27450

Land enableCustomElementPropertySupport for React 19 #27450

alunyov commented Oct 3, 2023 •

edited

Loading

react-sizebot commented Oct 3, 2023 •

edited

Loading

kassens commented Oct 11, 2023

alunyov commented Oct 11, 2023

sebmarkbage commented Oct 12, 2023

alunyov commented Oct 16, 2023

poteto left a comment

michaelwarren1106 commented Dec 5, 2023

gnoff commented Dec 7, 2023

klebba commented Jan 16, 2024 •

edited

Loading

rickhanlonii commented Jan 18, 2024 •

edited

Loading

klebba commented Jan 18, 2024 •

edited

Loading

rickhanlonii commented Jan 18, 2024

klebba commented Jan 18, 2024

rickhanlonii commented Mar 29, 2024

Land enableCustomElementPropertySupport for React 19 #27450

Land enableCustomElementPropertySupport for React 19 #27450

Conversation

alunyov commented Oct 3, 2023 • edited Loading

react-sizebot commented Oct 3, 2023 • edited Loading

Critical size changes

Significant size changes

kassens commented Oct 11, 2023

alunyov commented Oct 11, 2023

sebmarkbage commented Oct 12, 2023

alunyov commented Oct 16, 2023

poteto left a comment

Choose a reason for hiding this comment

michaelwarren1106 commented Dec 5, 2023

gnoff commented Dec 7, 2023

klebba commented Jan 16, 2024 • edited Loading

rickhanlonii commented Jan 18, 2024 • edited Loading

klebba commented Jan 18, 2024 • edited Loading

rickhanlonii commented Jan 18, 2024

klebba commented Jan 18, 2024

rickhanlonii commented Mar 29, 2024

alunyov commented Oct 3, 2023 •

edited

Loading

react-sizebot commented Oct 3, 2023 •

edited

Loading

klebba commented Jan 16, 2024 •

edited

Loading

rickhanlonii commented Jan 18, 2024 •

edited

Loading

klebba commented Jan 18, 2024 •

edited

Loading