-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zoom from special cases list #26631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
Opened by a member of the React Core Team
labels
Apr 15, 2023
Comparing: 7b0642b...0664786 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sophiebits
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait for a major probably
@sebmarkbage wait this has since been standardized. So I think we should keep it? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Looks like [it's getting removed anyway](https://groups.google.com/a/chromium.org/g/blink-dev/c/V7q43bgutbo/m/-7jneTl8CQAJ?pli=1). Maybe should wait for a major though. DiffTrain build for [f24cf4a](f24cf4a)
sophiebits
added a commit
that referenced
this pull request
Mar 29, 2024
This reverts commit f24cf4a.
sophiebits
added a commit
that referenced
this pull request
Mar 29, 2024
Reverts #26631 This got specced: w3c/csswg-drafts#9699 I left msZoom because it seems plausible someone will still be using it for backwards compat.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
Reverts #26631 This got specced: w3c/csswg-drafts#9699 I left msZoom because it seems plausible someone will still be using it for backwards compat. DiffTrain build for [19c7c29](19c7c29)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Looks like [it's getting removed anyway](https://groups.google.com/a/chromium.org/g/blink-dev/c/V7q43bgutbo/m/-7jneTl8CQAJ?pli=1). Maybe should wait for a major though.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Reverts facebook#26631 This got specced: w3c/csswg-drafts#9699 I left msZoom because it seems plausible someone will still be using it for backwards compat.
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it's getting removed anyway.
Maybe should wait for a major though.