Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_msgs): add traffic_light_type to msg #110

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

tzhong518
Copy link
Contributor

@tzhong518 tzhong518 commented Dec 14, 2023

Related Links

Description

This pull request add traffic_light_type attribute to the TrafficLightRoi.msg and TrafficSignal.msg, in order to distinguish traffic lights that are for pedestrians from that are for cars.
These messages are mainly used for traffic light recognition.

Related PR

autowarefoundation/autoware.universe#5871

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
@tzhong518 tzhong518 changed the title feat(tier4_perception_msgs): add traffic_light_type to roi msg feat(tier4_perception_msgs): add traffic_light_type to msg Dec 14, 2023
Signed-off-by: tzhong518 <sworgun@gmail.com>
@yukke42 yukke42 requested a review from miursh December 21, 2023 07:43
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzhong518 tzhong518 merged commit 29d1db4 into tier4/universe Dec 28, 2023
10 checks passed
@tzhong518 tzhong518 deleted the feat/traffic_light_type branch December 28, 2023 06:30
tzhong518 added a commit that referenced this pull request Jan 10, 2024
* add: traffic_light_type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: message type name

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
TomohitoAndo pushed a commit that referenced this pull request Jul 11, 2024
* add: traffic_light_type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: message type name

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants