Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk_traffic_light): add detector and classifier for pedestrian traffic light #5871

Merged
merged 52 commits into from
Dec 29, 2023

Conversation

tzhong518
Copy link
Contributor

@tzhong518 tzhong518 commented Dec 14, 2023

Description

Related links

Tests performed

Results: https://tier4.atlassian.net/wiki/spaces/~459732634/pages/2952200606

Please also checkout the related PRs when testing:
tier4/tier4_autoware_msgs#110
autowarefoundation/autoware_launch#752
autowarefoundation/autoware#4087
https://github.com/tier4/jetson_launcher/pull/35

command:
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=~/map/odaiba_pedtlr_edited/ vehicle_model:=jpntaxi sensor_model:=aip_xx1 vehicle_id:=2 map:=true sensing:=false localization:=false perception:=true planning:=false use_external_lane_change:=false control:=false rviz:=true

detector onnx: https://drive.google.com/file/d/1DSBHlWY6RS3wrLLb7K39LXmBwKXvd0zS/view?usp=drive_link
classifier onnx: https://drive.google.com/file/d/1XczUh6wuA7xU_xlwvM9LVLS-v3dXjKqY/view?usp=drive_link
edited map: https://drive.google.com/drive/folders/1jYobyhS_6F03J-60DV7O-YaguXcMaaur?usp=drive_link
tested rosbag: https://drive.google.com/drive/folders/1mylLtw2SBF0JQP03rpBddg8fH_yjhGAK?usp=drive_link
lamp_ped.txt: https://drive.google.com/file/d/1Gn-D0vM9Wf1R3B1kwwrRPpgqJ4O-dniD/view?usp=drive_link (Please put it under traffic_light_classifier/data)

To visualize the final result on the map, please add /perception/traffic_light_recognition/traffic_signals/markers to the Rviz.

Videos based on odaiba rosbag:
https://github.com/autowarefoundation/autoware.universe/assets/55872497/cf33b2dc-29e8-4b0a-a9ed-d5b84bbab48c
https://github.com/autowarefoundation/autoware.universe/assets/55872497/a3daa42d-500e-4a13-bcf6-ae08521000e9
https://github.com/autowarefoundation/autoware.universe/assets/55872497/e7d7e7cf-7919-4009-98bd-6ebf37689ce9
https://github.com/autowarefoundation/autoware.universe/assets/55872497/e73f3b00-f2f4-4cd0-aa69-72b2783556d8

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 14, 2023
pre-commit-ci bot and others added 5 commits December 14, 2023 07:09
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
@tzhong518 tzhong518 marked this pull request as ready for review December 14, 2023 07:56
@yukkysaito
Copy link
Contributor

If possible, could you post a video of the detection results here as well?

@tzhong518
Copy link
Contributor Author

If possible, could you post a video of the detection results here as well?

Yes, I attached them in the desription.

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: tzhong518 <sworgun@gmail.com>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@tzhong518 Could you fix CI errors?

tzhong518 and others added 4 commits December 28, 2023 14:59
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: tzhong518 <sworgun@gmail.com>
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

Comparison is base (3b0c254) 15.23% compared to head (7f9c4cc) 15.18%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ion/crosswalk_traffic_light_estimator/src/node.cpp 0.00% 75 Missing ⚠️
...tion/traffic_light_map_based_detector/src/node.cpp 0.00% 37 Missing ⚠️
.../traffic_light_occlusion_predictor/src/nodelet.cpp 0.00% 29 Missing ⚠️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% 8 Missing ⚠️
...eption/traffic_light_fine_detector/src/nodelet.cpp 0.00% 7 Missing ⚠️
...on/traffic_light_utils/src/traffic_light_utils.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5871      +/-   ##
==========================================
- Coverage   15.23%   15.18%   -0.06%     
==========================================
  Files        1750     1754       +4     
  Lines      120710   121165     +455     
  Branches    36740    36740              
==========================================
  Hits        18394    18394              
- Misses      81674    82129     +455     
  Partials    20642    20642              
Flag Coverage Δ *Carryforward flag
differential 3.79% <0.00%> (?)
total 15.24% <ø> (+<0.01%) ⬆️ Carriedforward from 3b0c254

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzhong518
Copy link
Contributor Author

CI errors are fixed.

@miursh miursh merged commit e9d3a8e into autowarefoundation:main Dec 29, 2023
19 of 24 checks passed
tzhong518 added a commit to tzhong518/autoware.universe that referenced this pull request Jan 10, 2024
…rian traffic light (autowarefoundation#5871)

* add: crosswalk traffic light recognition

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set conf=0 when occluded

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: refactor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: output not detected signals as unknown

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Revert "fix: output not detected signals as unknown"

This reverts commit 7a16659.

* Revert "fix: occlusion predictor"

This reverts commit 47d8cdd.

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean debug code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set max angle range for different type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: cancel the judge of flashing for estimated crosswalk traffic light

Signed-off-by: tzhong518 <sworgun@gmail.com>

* delete: not necessary judgement on label

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update perception/traffic_light_classifier/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: topic names and message attribute name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: model names

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* fix: argument position

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set classifier type in launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: function and parameter name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: func name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: move max angle range to config

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix: model name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: conflict

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: CI test

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
tzhong518 added a commit to tzhong518/autoware.universe that referenced this pull request Jan 31, 2024
…rian traffic light (autowarefoundation#5871)

* add: crosswalk traffic light recognition

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set conf=0 when occluded

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: refactor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: output not detected signals as unknown

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Revert "fix: output not detected signals as unknown"

This reverts commit 7a16659.

* Revert "fix: occlusion predictor"

This reverts commit 47d8cdd.

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean debug code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set max angle range for different type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: cancel the judge of flashing for estimated crosswalk traffic light

Signed-off-by: tzhong518 <sworgun@gmail.com>

* delete: not necessary judgement on label

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update perception/traffic_light_classifier/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: topic names and message attribute name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: model names

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* fix: argument position

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set classifier type in launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: function and parameter name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: func name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: move max angle range to config

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix: model name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: conflict

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: CI test

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…rian traffic light (autowarefoundation#5871)

* add: crosswalk traffic light recognition

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set conf=0 when occluded

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: refactor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: output not detected signals as unknown

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Revert "fix: output not detected signals as unknown"

This reverts commit 7a16659.

* Revert "fix: occlusion predictor"

This reverts commit 47d8cdd.

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean debug code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set max angle range for different type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: cancel the judge of flashing for estimated crosswalk traffic light

Signed-off-by: tzhong518 <sworgun@gmail.com>

* delete: not necessary judgement on label

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update perception/traffic_light_classifier/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: topic names and message attribute name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: model names

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* fix: argument position

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set classifier type in launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: function and parameter name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: func name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: move max angle range to config

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix: model name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: conflict

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: CI test

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…rian traffic light (autowarefoundation#5871)

* add: crosswalk traffic light recognition

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set conf=0 when occluded

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: refactor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: output not detected signals as unknown

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Revert "fix: output not detected signals as unknown"

This reverts commit 7a16659.

* Revert "fix: occlusion predictor"

This reverts commit 47d8cdd.

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean debug code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set max angle range for different type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: cancel the judge of flashing for estimated crosswalk traffic light

Signed-off-by: tzhong518 <sworgun@gmail.com>

* delete: not necessary judgement on label

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update perception/traffic_light_classifier/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: topic names and message attribute name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: model names

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* fix: argument position

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set classifier type in launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: function and parameter name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: func name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: move max angle range to config

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix: model name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: conflict

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: CI test

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…rian traffic light (autowarefoundation#5871)

* add: crosswalk traffic light recognition

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set conf=0 when occluded

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: refactor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: output not detected signals as unknown

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Revert "fix: output not detected signals as unknown"

This reverts commit 7a16659.

* Revert "fix: occlusion predictor"

This reverts commit 47d8cdd.

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean debug code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set max angle range for different type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: cancel the judge of flashing for estimated crosswalk traffic light

Signed-off-by: tzhong518 <sworgun@gmail.com>

* delete: not necessary judgement on label

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update perception/traffic_light_classifier/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: topic names and message attribute name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: model names

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* fix: argument position

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set classifier type in launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: function and parameter name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: func name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: move max angle range to config

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix: model name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: conflict

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: CI test

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…rian traffic light (autowarefoundation#5871)

* add: crosswalk traffic light recognition

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set conf=0 when occluded

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: refactor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: output not detected signals as unknown

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Revert "fix: output not detected signals as unknown"

This reverts commit 7a16659.

* Revert "fix: occlusion predictor"

This reverts commit 47d8cdd.

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean debug code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set max angle range for different type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: cancel the judge of flashing for estimated crosswalk traffic light

Signed-off-by: tzhong518 <sworgun@gmail.com>

* delete: not necessary judgement on label

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update perception/traffic_light_classifier/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: topic names and message attribute name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: model names

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* fix: argument position

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set classifier type in launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: function and parameter name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: func name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: move max angle range to config

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix: model name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: conflict

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: CI test

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 10, 2024
…rian traffic light (autowarefoundation#5871)

* add: crosswalk traffic light recognition

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set conf=0 when occluded

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: refactor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: output not detected signals as unknown

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Revert "fix: output not detected signals as unknown"

This reverts commit 7a16659.

* Revert "fix: occlusion predictor"

This reverts commit 47d8cdd.

* fix: occlusion predictor

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: clean debug code

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set max angle range for different type

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: cancel the judge of flashing for estimated crosswalk traffic light

Signed-off-by: tzhong518 <sworgun@gmail.com>

* delete: not necessary judgement on label

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update perception/traffic_light_classifier/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/include/crosswalk_traffic_light_estimator/node.hpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: topic names and message attribute name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* fix: model names

Signed-off-by: tzhong518 <sworgun@gmail.com>

* style(pre-commit): autofix

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/crosswalk_traffic_light_estimator/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_occlusion_predictor/src/nodelet.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* fix: argument position

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: set classifier type in launch file

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: function and parameter name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: func name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Update perception/traffic_light_map_based_detector/src/node.cpp

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* style(pre-commit): autofix

* fix: move max angle range to config

Signed-off-by: tzhong518 <sworgun@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix: model name

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: conflict

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: precommit

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: CI test

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: t4-x2 <grp-acl-git-x2@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants