forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multi_object_tracking): mot bicycle model revision, tracking_object_merger bugfix #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation#6082) * fix: bicycle model length on big vehicle Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: rear axis position fix in all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: repeat predict to limit dt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: implement repeating prediction to all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: bicycle model revision Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: fix centripetal acceleration, jacobian Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: equation on description, velocity index fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: markdown math Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor params Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: model slip process rate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: yaw rate limits Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor vx to vel, follow actual definition Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: acceleration uncertainty equation fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: twist covariance matrix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: explanations of Kalman filter matrices Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: slip angle process noise model revised Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: parameter tuning Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: use mahalanobis distance gate with larger threshold Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align tracker format Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…o-center length (autowarefoundation#6337) * fix: bicycle motion model - set minimum wheel-to-center length for stability Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align comments Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…towarefoundation#6343) * fix: tune parameters for pedestrian initial covariances and process noise Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactoring comments, aligning trackers Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…rdinate system (autowarefoundation#6457) fix(tracking_object_merger): merge velocity base on target object coordinate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
shmpwk
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YoshiRi
pushed a commit
that referenced
this pull request
Mar 14, 2024
fix(multi_object_tracking): mot bicycle model revision, tracking_object_merger bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cherry-picks of multi_object_tracking
autowarefoundation#6082
autowarefoundation#6337
autowarefoundation#6343
cherry-pick of tracking_object_merger
autowarefoundation#6457
Related links
fix for following issues
https://tier4.atlassian.net/browse/RT1-4914
https://tier4.atlassian.net/browse/RT1-5207
https://tier4.atlassian.net/browse/RT1-5343
https://tier4.atlassian.net/browse/RT1-5257
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.