-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multi_object_tracker): mot bicycle model revision #6082
feat(multi_object_tracker): mot bicycle model revision #6082
Conversation
6b8a8c6
to
99f93f2
Compare
99f93f2
to
7cfd267
Compare
746c807
to
eda2b3c
Compare
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
880abf9
to
154e6e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (There are some trivial suggestions and questions.)
Prediction Equation Changes:
|
I updated this branch to import #6278. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6082 +/- ##
==========================================
- Coverage 14.38% 14.37% -0.02%
==========================================
Files 1907 1907
Lines 129935 130076 +141
Branches 37616 37616
==========================================
Hits 18697 18697
- Misses 90229 90370 +141
Partials 21009 21009
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…arefoundation#6082)" This reverts commit dbdc238.
…ation#6082) * fix: bicycle model length on big vehicle Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: rear axis position fix in all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: repeat predict to limit dt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: implement repeating prediction to all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: bicycle model revision Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: fix centripetal acceleration, jacobian Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: equation on description, velocity index fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: markdown math Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor params Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: model slip process rate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: yaw rate limits Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor vx to vel, follow actual definition Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: acceleration uncertainty equation fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: twist covariance matrix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: explanations of Kalman filter matrices Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: slip angle process noise model revised Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: parameter tuning Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: use mahalanobis distance gate with larger threshold Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align tracker format Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ation#6082) * fix: bicycle model length on big vehicle Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: rear axis position fix in all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: repeat predict to limit dt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: implement repeating prediction to all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: bicycle model revision Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: fix centripetal acceleration, jacobian Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: equation on description, velocity index fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: markdown math Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor params Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: model slip process rate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: yaw rate limits Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor vx to vel, follow actual definition Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: acceleration uncertainty equation fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: twist covariance matrix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: explanations of Kalman filter matrices Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: slip angle process noise model revised Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: parameter tuning Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: use mahalanobis distance gate with larger threshold Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align tracker format Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ation#6082) * fix: bicycle model length on big vehicle Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: rear axis position fix in all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: repeat predict to limit dt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: implement repeating prediction to all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: bicycle model revision Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: fix centripetal acceleration, jacobian Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: equation on description, velocity index fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: markdown math Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor params Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: model slip process rate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: yaw rate limits Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor vx to vel, follow actual definition Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: acceleration uncertainty equation fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: twist covariance matrix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: explanations of Kalman filter matrices Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: slip angle process noise model revised Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: parameter tuning Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: use mahalanobis distance gate with larger threshold Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align tracker format Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* chore(build): remove tier4_autoware_utils.hpp perception/ (autowarefoundation#4843) removed tier4_autoware_utils.hpp in perception/ Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> * feat(multi_object_tracker): mot bicycle model revision (autowarefoundation#6082) * fix: bicycle model length on big vehicle Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: rear axis position fix in all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: repeat predict to limit dt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: implement repeating prediction to all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: bicycle model revision Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: fix centripetal acceleration, jacobian Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: equation on description, velocity index fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: markdown math Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor params Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: model slip process rate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: yaw rate limits Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor vx to vel, follow actual definition Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: acceleration uncertainty equation fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: twist covariance matrix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: explanations of Kalman filter matrices Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: slip angle process noise model revised Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: parameter tuning Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: use mahalanobis distance gate with larger threshold Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align tracker format Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * fix(multi_object_tracker): bicycle motion model - set minimum wheel-to-center length (autowarefoundation#6337) * fix: bicycle motion model - set minimum wheel-to-center length for stability Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align comments Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Co-authored-by: Taekjin LEE <technolojin@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ation#6082) * fix: bicycle model length on big vehicle Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: rear axis position fix in all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: repeat predict to limit dt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: implement repeating prediction to all modalities Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: bicycle model revision Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: fix centripetal acceleration, jacobian Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: equation on description, velocity index fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: markdown math Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor params Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: model slip process rate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: yaw rate limits Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: refactor vx to vel, follow actual definition Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: acceleration uncertainty equation fix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: twist covariance matrix Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: explanations of Kalman filter matrices Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: slip angle process noise model revised Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat: parameter tuning Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: use mahalanobis distance gate with larger threshold Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * chore: align tracker format Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Description
Revise bicycle motion model.
*VehicleTracke::*VehicleTracker
lf_
,lr_
lr
is the distance from the center of the object.*Tracker::predict(const rclcpp::Time & time)
Eigen::MatrixXd Q
object.kinematics.twist_with_covariance
vx
tovel
(velocity in the tracking model is not a vector.)This PR contains multiple changes since one of the changes can cause instability of tracking results. The multiple changes are incorporated for stability and trackability.
Related links
https://tier4.atlassian.net/browse/RT1-4914
Tests performed
Simulations of sensing and perception modules were performed under a tier4 deployment.
Blue objects: Detected objects
Red objects: Recorded predicted objects
Yellow objects: Predicted objects done by the revised tracker
mot-bicycle-revision-cross-section5.mp4
The revised tracker tracks yaw rate better than before. As result, the predicted objects follows turning objects well.
mot-bicycle-revision-after-corner.mp4
In tracking objects that turn and then move straight, the uncertainty of the yaw rate is set larger to avoid overestimating the turning.
mot-bicycle-revision-straight-truck.mp4
No performance degradation is observed in a tracking straight-moving object.
It can be seen that the revised tracker reduces position uncertainty (covariance matrix) by accumulating measurements.
Notes for reviewers
The Mahalanobis distances gate threshold is enlarged.
Interface changes
Not applicable.
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.