-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracking_object_merger): merge velocity base on target object coordinate system #6457
fix(tracking_object_merger): merge velocity base on target object coordinate system #6457
Conversation
…rdinate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@YoshiRi May I request a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6457 +/- ##
==========================================
- Coverage 15.13% 15.13% -0.01%
==========================================
Files 1819 1819
Lines 126013 126017 +4
Branches 38180 38180
==========================================
Hits 19073 19073
- Misses 85551 85556 +5
+ Partials 21389 21388 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…rdinate system (autowarefoundation#6457) fix(tracking_object_merger): merge velocity base on target object coordinate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…rdinate system (autowarefoundation#6457) fix(tracking_object_merger): merge velocity base on target object coordinate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…rdinate system (#6457) fix(tracking_object_merger): merge velocity base on target object coordinate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…rdinate system (autowarefoundation#6457) fix(tracking_object_merger): merge velocity base on target object coordinate Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Description
Related previous work (PR) : #5853
The multi-object tracker (mainly from lidar, blue box) has opposite direction and when the radar object is also used to obtain velocity, the merger trusts the orientation of the main object (lidar object). As result, the merged object (yellow box) has the reversed direction.
tracker_merge_reversed_obj.mp4
Previous
Current tracked object merger treats velocity as scalar value, and determine its direction based on some logic which causes this issue.
Fixed
The velocity merger converts measured velocity vector to target object coordinate system.
TIER IV INTERNAL
Tests performed
Tested on recordings had the relevant issue
tracker_merge_reversed_obj_fixed_3.mp4
Effects on system behavior
The merged result will not have artificial result of velocity orientation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.