Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracking_object_merger): merge velocity base on target object coordinate system #6457

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Feb 20, 2024

Description

Related previous work (PR) : #5853

The multi-object tracker (mainly from lidar, blue box) has opposite direction and when the radar object is also used to obtain velocity, the merger trusts the orientation of the main object (lidar object). As result, the merged object (yellow box) has the reversed direction.

tracker_merge_reversed_obj.mp4

Previous
Current tracked object merger treats velocity as scalar value, and determine its direction based on some logic which causes this issue.

Fixed
The velocity merger converts measured velocity vector to target object coordinate system.

TIER IV INTERNAL

Tests performed

Tested on recordings had the relevant issue

tracker_merge_reversed_obj_fixed_3.mp4

Effects on system behavior

The merged result will not have artificial result of velocity orientation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…rdinate

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 20, 2024
@technolojin technolojin marked this pull request as ready for review February 20, 2024 05:56
@technolojin technolojin self-assigned this Feb 20, 2024
@yukkysaito
Copy link
Contributor

@YoshiRi May I request a review?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 20, 2024
@technolojin technolojin enabled auto-merge (squash) February 20, 2024 07:27
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c67bbe7) 15.13% compared to head (8c3a43a) 15.13%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ception/tracking_object_merger/src/utils/utils.cpp 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6457      +/-   ##
==========================================
- Coverage   15.13%   15.13%   -0.01%     
==========================================
  Files        1819     1819              
  Lines      126013   126017       +4     
  Branches    38180    38180              
==========================================
  Hits        19073    19073              
- Misses      85551    85556       +5     
+ Partials    21389    21388       -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.13% <ø> (+<0.01%) ⬆️ Carriedforward from dd52489

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin merged commit 82864fb into autowarefoundation:main Feb 20, 2024
20 of 23 checks passed
technolojin added a commit to tier4/autoware.universe that referenced this pull request Feb 21, 2024
…rdinate system (autowarefoundation#6457)

fix(tracking_object_merger): merge velocity base on target object coordinate

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…rdinate system (autowarefoundation#6457)

fix(tracking_object_merger): merge velocity base on target object coordinate

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…rdinate system (#6457)

fix(tracking_object_merger): merge velocity base on target object coordinate

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…rdinate system (autowarefoundation#6457)

fix(tracking_object_merger): merge velocity base on target object coordinate

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin deleted the fix/tracking_obj_merger-velocity-merge branch July 26, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants