Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0058: Graceful Termination - Promotions and Deprecation #4611

Closed
jerop opened this issue Feb 23, 2022 · 11 comments · Fixed by #4668 or #5022
Closed

TEP-0058: Graceful Termination - Promotions and Deprecation #4611

jerop opened this issue Feb 23, 2022 · 11 comments · Fixed by #4668 or #5022
Assignees
@abayer @vinamra28
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Pipelines v0.38

Comments

@jerop
Copy link
Member

jerop commented Feb 23, 2022 •
edited
Loading

In TEP-0058: Graceful Termination, we deprecated PipelineRunCancelled and added:

  • StoppedRunFinally - To "stop" (i.e. let the tasks complete, then execute finally tasks) a Pipeline
  • CancelledRunFinally - To "cancel" (i.e. interrupt any executing non finally tasks, then execute finally tasks)
  • Cancelled - Same as today's PipelineRunCancelled - i.e. interrupt any executing tasks without running finally tasks

The above was released in v0.25 in June 2021.

The new fields are still in alpha, so this issue tracks promoting them to beta. This issue also tracks deprecation and removal of PipelineRunCancelled.
@jerop jerop added kind/feature Categorizes issue or PR as related to a new feature. area/api Indicates an issue or PR that deals with the API. labels Feb 23, 2022
jerop added a commit to jerop/pipeline that referenced this issue Feb 23, 2022
@jerop
TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated
0a7e0fe 
In [TEP-0058: Graceful Termination][tep-0058], we deprecated `PipelineRunCancelled`
and added:
- `StoppedRunFinally` - To "stop" (i.e. let the tasks complete, then execute finally
tasks) a Pipeline
- `CancelledRunFinally` - To "cancel" (i.e. interrupt any executing non finally tasks,
then execute finally tasks)
- `Cancelled` - Same as today's `PipelineRunCancelled` - i.e. interrupt any executing
 tasks without running finally tasks

The above was released in [v0.25][25] in June 2021.

This change adds the deprecated field - `PipelineRunCancelled` - to the deprecation table.

Issue: tektoncd#4611

[tep-0058]: https://github.com/tektoncd/community/blob/main/teps/0058-graceful-pipeline-run-termination.md)
[25]: https://github.com/tektoncd/pipeline/releases/tag/v0.25.0
jerop added a commit to jerop/pipeline that referenced this issue Feb 23, 2022
@jerop
TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated
3d0bf4c 
In [TEP-0058: Graceful Termination][tep-0058], we deprecated `PipelineRunCancelled`
and added:
- `StoppedRunFinally` - To "stop" (i.e. let the tasks complete, then execute finally
tasks) a Pipeline
- `CancelledRunFinally` - To "cancel" (i.e. interrupt any executing non finally tasks,
then execute finally tasks)
- `Cancelled` - Same as today's `PipelineRunCancelled` - i.e. interrupt any executing
 tasks without running finally tasks

The above was released in [v0.25][v25] in June 2021.

This change adds the deprecated field - `PipelineRunCancelled` - to the deprecation table.

Issue: tektoncd#4611

[tep-0058]: https://github.com/tektoncd/community/blob/main/teps/0058-graceful-pipeline-run-termination.md)
[v25]: https://github.com/tektoncd/pipeline/releases/tag/v0.25.0
jerop added a commit to jerop/pipeline that referenced this issue Feb 23, 2022
@jerop
TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated
abadc67 
In [TEP-0058: Graceful Termination][tep-0058], we deprecated `PipelineRunCancelled`
and added:
- `StoppedRunFinally` - To "stop" (i.e. let the tasks complete, then execute finally
tasks) a Pipeline
- `CancelledRunFinally` - To "cancel" (i.e. interrupt any executing non finally tasks,
then execute finally tasks)
- `Cancelled` - Same as today's `PipelineRunCancelled` - i.e. interrupt any executing
 tasks without running finally tasks

The above was released in [v0.25][v25] in June 2021.

This change adds the deprecated field - `PipelineRunCancelled` - to the deprecation table.

Issue: tektoncd#4611

[tep-0058]: https://github.com/tektoncd/community/blob/main/teps/0058-graceful-pipeline-run-termination.md
[v25]: https://github.com/tektoncd/pipeline/releases/tag/v0.25.0
@jerop jerop mentioned this issue Feb 23, 2022
Merged
4 tasks
@lbernick lbernick moved this to Todo in Pipelines V1 Feb 23, 2022
@jerop
Copy link
Member Author

jerop commented Feb 23, 2022

@tektoncd/core-maintainers thoughts on promoting the new fields for graceful termination to beta? they were released in v0.25 so they've been in use for 8 months so far

@pritidesai
Copy link
Member

yup definitely 👍

tekton-robot pushed a commit that referenced this issue Feb 23, 2022
@jerop @tekton-robot
TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated
4a06c48 
In [TEP-0058: Graceful Termination][tep-0058], we deprecated `PipelineRunCancelled`
and added:
- `StoppedRunFinally` - To "stop" (i.e. let the tasks complete, then execute finally
tasks) a Pipeline
- `CancelledRunFinally` - To "cancel" (i.e. interrupt any executing non finally tasks,
then execute finally tasks)
- `Cancelled` - Same as today's `PipelineRunCancelled` - i.e. interrupt any executing
 tasks without running finally tasks

The above was released in [v0.25][v25] in June 2021.

This change adds the deprecated field - `PipelineRunCancelled` - to the deprecation table.

Issue: #4611

[tep-0058]: https://github.com/tektoncd/community/blob/main/teps/0058-graceful-pipeline-run-termination.md
[v25]: https://github.com/tektoncd/pipeline/releases/tag/v0.25.0
@jerop
Copy link
Member Author

jerop commented Feb 28, 2022 •
edited
Loading

discussed in API WG on 02-28-2022 (recording | notes): general agreement to promote graceful termination to beta

@jerop jerop added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 28, 2022
@jerop
Copy link
Member Author

jerop commented Mar 8, 2022

thank you @vinamra28 for volunteering to help us with this 😀

/assign @vinamra28

@tekton-robot
Copy link
Collaborator

@jerop: GitHub didn't allow me to assign the following users: vinamra28.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

thank you @vinamra28 for volunteering to help us with this 😀

/assign @vinamra28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vinamra28
Copy link
Member

/assign

@vinamra28 vinamra28 mentioned this issue Mar 15, 2022
Merged
5 tasks
@jerop jerop mentioned this issue Mar 22, 2022
Closed
@vinamra28
Copy link
Member

vinamra28 commented Apr 5, 2022 •
edited
Loading

@jerop @pritidesai I guess removal of PipelineRunCancelled status won't be a good idea atm because old + current releases of CLI are still pointing to this status and removal of this would break previous versions of CLI, i.e., a user using an older version of CLI (specifically, N, N-1 and N-2) wouldn't be able to cancel their PipelineRun if they install latest Pipelines on their cluster. They'll have to force upgrade their CLI to latest in order to cancel their pipelines. My thought would be:

  • Promote graceful termination from alpha to stable
  • Notify the dependent tools(such as CLI, dashboard, etc) and users about the removal of PipelineRunCancelled status and give them time frame so that they can migrate
  • After that given time frame remove PipelineRunCancelled support

Any thoughts?

@vinamra28
Copy link
Member

created an issue in CLI to track this

@AlanGreene AlanGreene mentioned this issue Apr 5, 2022
Closed
@lbernick lbernick moved this from Todo to In Progress in Pipelines V1 Apr 19, 2022
Repository owner moved this from In Progress to Done in Pipelines V1 Apr 21, 2022
@lbernick
Copy link
Member

/reopen

I think we still need to remove PipelineRunCancelledDeprecated

@tekton-robot tekton-robot reopened this Apr 21, 2022
@tekton-robot
Copy link
Collaborator

@lbernick: Reopened this issue.

In response to this:

/reopen

I think we still need to remove PipelineRunCancelledDeprecated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abayer
Copy link
Contributor

abayer commented Jun 22, 2022

/assign

I'll be doing this once #5005 is merged, since it'll be simpler once PipelineRun v1alpha1 is gone.

abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jun 22, 2022
@abayer
Remove deprecated PipelineRunSpecStatusCancelledDeprecated
add0dae 
Fixes tektoncd#4611.

We deprecated the original cancelled status (with the value `PipelineRunCancelled`) in tektoncd#3915, and we're now at the time for it to be removed in favor of the value `Cancelled`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer mentioned this issue Jun 22, 2022
Merged
5 tasks
@afrittoli afrittoli removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 28, 2022
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jun 30, 2022
@abayer
Remove deprecated PipelineRunSpecStatusCancelledDeprecated
c7b2c0b 
Fixes tektoncd#4611.

We deprecated the original cancelled status (with the value `PipelineRunCancelled`) in tektoncd#3915, and we're now at the time for it to be removed in favor of the value `Cancelled`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit that referenced this issue Jul 1, 2022
@abayer @tekton-robot
Remove deprecated PipelineRunSpecStatusCancelledDeprecated
d71d7db 
Fixes #4611.

We deprecated the original cancelled status (with the value `PipelineRunCancelled`) in #3915, and we're now at the time for it to be removed in favor of the value `Cancelled`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abayer abayer

@vinamra28 vinamra28

Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Pipelines V1
Status: Done
Milestone
Pipelines v0.38
7 participants
@abayer @pritidesai @afrittoli @jerop @vinamra28 @lbernick @tekton-robot