Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel PipelineRun using Cancelled status instead of PipelineRunCancelled #1553

Closed
vinamra28 opened this issue Apr 5, 2022 · 1 comment · Fixed by #1554
Closed

Cancel PipelineRun using Cancelled status instead of PipelineRunCancelled #1553

vinamra28 opened this issue Apr 5, 2022 · 1 comment · Fixed by #1554
Assignees
@vinamra28
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@vinamra28
Copy link
Member

As of today if we want to cancel a PipelineRun forcefully, CLI uses PipelineRunCancelled status which is deprecated. With tektoncd/pipeline#4668, Cancelled can be used in place of PipelineRunCancelled status to cancel a PipelineRun forcefully as it's being moved out of feature-flags. Moreover, we need to add backward compatible support for the case where user is using latest CLI version but the Pipelines version installed on the cluster is an older one.

/kind feature
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 5, 2022
@vinamra28 vinamra28 mentioned this issue Apr 5, 2022
Closed
@vdemeester vdemeester added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 6, 2022
@vinamra28
Copy link
Member Author

/assign

@vinamra28 vinamra28 mentioned this issue Apr 8, 2022
Merged
4 tasks
@AlanGreene AlanGreene mentioned this issue Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinamra28 vinamra28

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cancel PipelineRuns using Cancelled status vinamra28/cli
3 participants
@vdemeester @vinamra28 @tekton-robot