TEP-0058: Graceful Termination - PipelineRunCancelled is deprecated
#4612
Conversation
In [TEP-0058: Graceful Termination][tep-0058], we deprecated `PipelineRunCancelled` and added: - `StoppedRunFinally` - To "stop" (i.e. let the tasks complete, then execute finally tasks) a Pipeline - `CancelledRunFinally` - To "cancel" (i.e. interrupt any executing non finally tasks, then execute finally tasks) - `Cancelled` - Same as today's `PipelineRunCancelled` - i.e. interrupt any executing tasks without running finally tasks The above was released in [v0.25][v25] in June 2021. This change adds the deprecated field - `PipelineRunCancelled` - to the deprecation table. Issue: tektoncd#4611 [tep-0058]: https://github.com/tektoncd/community/blob/main/teps/0058-graceful-pipeline-run-termination.md [v25]: https://github.com/tektoncd/pipeline/releases/tag/v0.25.0
|
/lgtm |
|
thank you @jerop, please add this announcement in the release notes 🙏 |
|
@pritidesai it was already announced in v0.25, just not added to the deprecations table - do you think we need to announce again? Edit: added a reminder in the release notes |
|
thank you @jerop, its my misunderstanding, I thought we are removing the flag in the next release (0.34 - March 2022). This is just an update the the deprecation table. When are we removing the flag then? with V1? or after promoting graceful termination to beta? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
In TEP-0058: Graceful Termination, we deprecated
PipelineRunCancelledand added:StoppedRunFinally- To "stop" (i.e. let the tasks complete, then execute finally tasks) a PipelineCancelledRunFinally- To "cancel" (i.e. interrupt any executing non finally tasks, then execute finally tasks)Cancelled- Same as today'sPipelineRunCancelled- i.e. interrupt any executing tasks without running finally tasksThe above was released in v0.25 in June 2021.
This change adds the deprecated field -
PipelineRunCancelled- to the deprecation table.Issue: #4611
Pull Requests:
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes