Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated PipelineRunSpecStatusCancelledDeprecated #5022

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Remove deprecated PipelineRunSpecStatusCancelledDeprecated #5022

merged 1 commit into from
Jul 1, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Jun 22, 2022

Changes

Fixes #4611.

We deprecated the original cancelled status (with the value PipelineRunCancelled) in #3915, and we're now at the time for it to be removed in favor of the value Cancelled.

An email will be sent to tekton-dev@ alerting people to this change once it merges.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Deprecated `PipelineRunCancelled` status string removed; use `Cancelled` instead.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 22, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 22, 2022
@abayer
Copy link
Contributor Author

abayer commented Jun 22, 2022

/hold

This is on top of #5005 (which removes most of v1alpha1), so as to avoid dealing with the messier usage of PipelineRunCancelled in v1alpha1, so it's on hold until that has merged.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/cancel.go 93.2% 93.0% -0.2
pkg/reconciler/pipelinerun/resources/pipelineref.go 87.5% 85.7% -1.8
pkg/reconciler/taskrun/resources/taskref.go 78.6% 83.0% 4.4

@abayer abayer marked this pull request as draft June 22, 2022 20:01
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/cancel.go 93.2% 93.0% -0.2
pkg/reconciler/pipelinerun/resources/pipelineref.go 87.5% 85.7% -1.8
pkg/reconciler/taskrun/resources/taskref.go 78.6% 83.0% 4.4

@abayer
Copy link
Contributor Author

abayer commented Jun 22, 2022

/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-alpha-integration-tests

@abayer abayer force-pushed the remove-pipelineruncancelled branch from 9517c45 to add0dae Compare June 22, 2022 21:03
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/cancel.go 93.2% 93.0% -0.2
pkg/reconciler/pipelinerun/resources/pipelineref.go 87.5% 85.7% -1.8
pkg/reconciler/taskrun/resources/taskref.go 78.6% 83.0% 4.4

@vdemeester
Copy link
Member

/cc @vinamra28 @tektoncd/cli-maintainers do we feel confident this won't be a huge deal for cli ? I think we supported this only recently 🙃

@vinamra28
Copy link
Member

/cc @vinamra28 @tektoncd/cli-maintainers do we feel confident this won't be a huge deal for cli ? I think we supported this only recently 🙃

@vdemeester yep, CLI can handle this easily.

@lbernick lbernick self-assigned this Jun 28, 2022
lbernick
lbernick approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

since the deprecation table states that this won't be removed until July 12 (and also until this is rebased-- but I'm assuming that's why this is a draft)

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 28, 2022
@abayer
Remove deprecated PipelineRunSpecStatusCancelledDeprecated
c7b2c0b 
Fixes tektoncd#4611.

We deprecated the original cancelled status (with the value `PipelineRunCancelled`) in tektoncd#3915, and we're now at the time for it to be removed in favor of the value `Cancelled`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer force-pushed the remove-pipelineruncancelled branch from add0dae to c7b2c0b Compare June 30, 2022 19:28
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2022
@abayer abayer marked this pull request as ready for review June 30, 2022 19:28
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 30, 2022
@abayer
Copy link
Contributor Author

abayer commented Jun 30, 2022

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2022
@abayer
Copy link
Contributor Author

abayer commented Jun 30, 2022

@lbernick Since there won't be a release between now and July 12, this should be mergeable now.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/cancel.go 93.2% 93.0% -0.2

@abayer
Copy link
Contributor Author

abayer commented Jun 30, 2022

/retest

vinamra28
vinamra28 reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

@vinamra28: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerop
Copy link
Member

jerop commented Jul 1, 2022

thanks @abayer!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@tekton-robot tekton-robot merged commit d71d7db into tektoncd:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@lbernick lbernick lbernick approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TEP-0058: Graceful Termination - Promotions and Deprecation
6 participants
@abayer @tekton-robot @vdemeester @vinamra28 @jerop @lbernick