Updating fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rule-design: Update random ID generator Replace the hex generator with an alphanumeric number generator. * Update pages/design/rule-design.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jey Nandakumar <jey.nandakumar@gmail.com>
* image-button-acc: remove unnecessary note * Update image-button-non-empty-accessible-name-59796f.md * Update image-button-non-empty-accessible-name-59796f.md
* Move applicability notes to background * Improve assumption * Upgrade examples descriptions * Reorder Inapplicable examples
* html-page-title: minimise the number of notes * Update _rules/html-page-title-2779a5.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update html-page-title-2779a5.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jey Nandakumar <jey.nandakumar@gmail.com>
* pag-lang-valid: minimise the number of notes * Update html-page-lang-valid-bf051a.md Co-authored-by: Jey Nandakumar <jey.nandakumar@gmail.com>
* page-lang-xml-lang: minimise the number of notes * Update html-page-lang-xml-lang-match-5b7ae0.md * Update html-page-lang-xml-lang-match-5b7ae0.md * Apply suggestions from code review Co-authored-by: carlosapaduarte <carlosapaduarte@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update html-page-lang-xml-lang-match-5b7ae0.md Co-authored-by: carlosapaduarte <carlosapaduarte@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jey <jey.nandakumar@gmail.com>
* new rule: Auto-updating text content can be paused or stopped * update spelling-ignore.yml * Fix spelling test * Uppercase ASCII * Allow ascii * Rephrased applicability and assumptions. Updated background. * Added example with an essential progress bar * Processed changes requested by Jean-Yves * added note to expectations, updated assumption and details on the examples * Updated applicability and examples * Update frontmatter * Changes requested * Spelling update * Updated applicability, plus new definitions * Corrected spelling * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Renaming the definition * Update definition of user interaction * Updated examples code * Update example * Update function name * Update to use the new function name * Update applicability to focus on text content that updates with a determinable frequency, which is something that should be objectively determined. Remove now unused definition. * Updated applicability, expectations and example descriptions * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update spelling-ignore.yml * Update asset name * Added second assumption * Update auto-update-text-efbfc7.md Updated applicability to address issues related to the action => update causality Updated expectation to consider the possibility of the user changing the frequency of the updates I still need to further update the expectation and examples * Updated examples and included second expectation * Update auto-update-text-efbfc7.md * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Create mechanism.md * Update auto-update-text-efbfc7.md * Update mechanism.md * Update mechanism.md * Updated definition of mechanism * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update auto-update-text-efbfc7.md * Updates to expectation and definition * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md Siblings are not needed (the ancestor innerText captures that) * Updated applicability and examples * Spelling fixes * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update pages/glossary/user-interaction.md Co-Authored-By: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update auto-update-text-efbfc7.md * Update user-interaction.md * Update spelling-ignore.yml * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Apply suggestions from code review Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update auto-update-text-efbfc7.md * Update spelling-ignore.yml * Apply suggestions from code review * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update _rules/auto-update-text-efbfc7.md Co-Authored-By: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Remove unused definitions * Update _rules/auto-update-text-efbfc7.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update expectation to account for instructions * Removed unused definition * Updated description of passed example 5 * Introduced definition of clearly labelled location * Update clearly-labelled-location.md * Spelling corrections * Update pages/glossary/clearly-labeled-location.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update clearly-labeled-location.md * Update example description * Update auto-update-text-efbfc7.md * Update auto-update-text-efbfc7.md * Apply suggestions from code review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update clearly-labeled-location.md * Added assumption for other ways to control auto-updating * Combining expectations 1 and 2 * Revising description * Update clearly-labeled-location.md * Update auto-update-text-efbfc7.md * Update user-interaction.md * Update clearly-labeled-location.md * Updates based on requested changes * Update clearly-labeled-location.md * Update clearly-labeled-location.md * Update clearly-labeled-location.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* Create definition of attribute value * Use new def in rules
* form-controls-acc-name: Modernise the rule * editorial updates * Update form-control-non-empty-accessible-name-e086e5.md * fix failing tests * Apply suggestions from code review Co-authored-by: Carlos <carlosapaduarte@gmail.com> * Update form-control-non-empty-accessible-name-e086e5.md * Update _rules/form-control-non-empty-accessible-name-e086e5.md Co-authored-by: Carlos <carlosapaduarte@gmail.com> * Apply suggestions from code review Co-authored-by: Adil Hussain <42895421+adilsofficial@users.noreply.github.com> * Update form-control-non-empty-accessible-name-e086e5.md Co-authored-by: Carlos <carlosapaduarte@gmail.com> Co-authored-by: Adil Hussain <42895421+adilsofficial@users.noreply.github.com>
* Add condition list instructions to rule design doc * Update rule-design.md * Update rule-design.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jey Nandakumar <jey.nandakumar@gmail.com> * Update pages/design/rule-design.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update spelling-ignore.yml * Update spelling-ignore.yml * Apply suggestions from code review Co-authored-by: Carlos <carlosapaduarte@gmail.com> * Update rule-design.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jey Nandakumar <jey.nandakumar@gmail.com> Co-authored-by: Carlos <carlosapaduarte@gmail.com>
… review to rule. (#1364) * Added act tf changes to rule. * fix spacing Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Jey <jey.nandakumar@gmail.com>
* Add definition of marked as decorative * Add new rule * Accept images without alt attribute
* New rule No keyboard shortcuts use only letter, number, sign or punctuation keys Reviews required * New rule No functions are exclusively operated through device motion Set of manual rules for SC 2.5.4: Motion Actuation * Delete active-focus-shortcut-1e9941.md * Delete no-single-key-shortcut-ffbc54.md * Delete remap-shortcut-aa8b52.md * Delete turn-off-shortcut-670a30.md * Rename device-motion-bf0de1.md to _rules/device-motion-bf0de1.md * Rename motion-disabled-de951c.md to _rules/motion-disabled-de951c.md * Rename motion-replaced-5d9784.md to _rules/motion-replaced-5d9784.md * Update device-motion-bf0de1.md * updated rule 'No functions are exclusively operated through device motion' * Update motion-actuation-bf0de1.md * Update motion-actuation-bf0de1.md * updated rule * fixed missing h2 header (Failed examples) * updated frontmatter. Updated definitions and rule examples * Composite rule name updated * Update _rules/device-motion-disabled-c249d5.md Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/device-motion-disabled-c249d5.md Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Apply suggestions from code review Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update device-motion-user-interface-7677a9.md * Update device-motion-user-interface-7677a9.md * Update device-motion-disabled-c249d5.md * Delete user-motion-user-interface-9d42d6.md * Delete user-motion-disabled-ed12b1.md * Delete motion-actuation-bf0de1.md * Update device-motion-disabled-c249d5.md * Update device-motion-user-interface-7677a9.md * Update device-motion-user-interface-7677a9.md * Create slider.js * Update device-motion-disabled-c249d5.md * Update slider.js * Update device-motion-disabled-c249d5.md * Update device-motion-user-interface-7677a9.md * Update device-motion-disabled-c249d5.md * Update device-motion-user-interface-7677a9.md * Update device-motion-user-interface-7677a9.md * Update spelling-ignore.yml * Apply suggestions from code review Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update slider.js * Update slider.js * Update device-motion-user-interface-7677a9.md * Update device-motion-disabled-c249d5.md * Update device-motion-user-interface-7677a9.md * Apply suggestions from code review Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update device-motion-disabled-c249d5.md * Update device-motion-user-interface-7677a9.md * Delete device-motion-user-interface-7677a9.md Moved to PR #1276 * Apply suggestions from code review Co-Authored-By: Jean-Yves Moyen <jym@siteimprove.com> * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update device-motion-disabled-c249d5.md * Update _rules/device-motion-disabled-c249d5.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update device-motion-disabled-c249d5.md * Apply suggestions from code review Co-authored-by: Adil Hussain <42895421+adilsofficial@users.noreply.github.com> * fix spelling * Create instrument.md * Create changes-in-content.md * Create clearly-labeled-location.md * Update spelling-ignore.yml Co-authored-by: carlosapaduarte <carlosapaduarte@gmail.com> Co-authored-by: joecron <55736288+joecron@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Jey Nandakumar <jey.nandakumar@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Carlos <caduarte@campus.ul.pt> Co-authored-by: Adil Hussain <42895421+adilsofficial@users.noreply.github.com>
…ted from the user interface (#1276) * Create device-motion-user-interface-7677a9.md * Update device-motion-user-interface-7677a9.md * Apply suggestions from code review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update device-motion-user-interface-7677a9.md * Update device-motion-user-interface-7677a9.md * Update device-motion-user-interface-7677a9.md * Remove expectation 2 and 3 and examples * Replaced "outcomes" and added an expectation about the location of the set of instruments * Removed unused definitions * Update device-motion-user-interface-7677a9.md * Add example * Update _rules/device-motion-user-interface-7677a9.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Links to SC * Fix typo * Updated expectation 2 * Update example description * Update device-motion-user-interface-7677a9.md * Create changes-in-content.md * Update device-motion-user-interface-7677a9.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update device-motion-user-interface-7677a9.md New passed example * Update changes-in-content.md * Update changes-in-content.md * Update changes-in-content.md * Update device-motion-user-interface-7677a9.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Updating to dom events * Updated changes in content and rule accordingly * Update device-motion-user-interface-7677a9.md * Update changes-in-content.md * Update device-motion-user-interface-7677a9.md * spelling mistake * Update device-motion-user-interface-7677a9.md * Fixes for passing tests * Update spelling-ignore.yml Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
* Update aria-required-owned-element-bc4a75.md Three notes from the Applicability section added to the background section. The first note with the `tablist` element removed. * correcting the typo * Editorial changes to the section describing how DPUB handles role inheritance.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* New rule: image accessible name descriptive * editorial improvements * Apply suggestions from code review Co-authored-by: Carlos <carlosapaduarte@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * updated based on feedback * Apply suggestions from code review Co-authored-by: Carlos <carlosapaduarte@gmail.com> * tweaked the description Co-authored-by: Carlos <carlosapaduarte@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
…r TF review (#1363) * Update format of example descriptions * Remove notes * Update list format * Remove not used definitions * Update _rules/table-header-cells-refer-to-data-cells-d0f69e.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update table-header-cells-refer-to-data-cells-d0f69e.md * Updates from review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update aria-required-owned-element-bc4a75.md Three notes from the Applicability section added to the background section. The first note with the `tablist` element removed. * Re-wording the definition so that it references the control group * Update pages/glossary/appropriate-field-for-the-form-control.md Co-authored-by: Carlos <carlosapaduarte@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
* page-has-title: improve example description Change suggested by AWK on a survey from AGWG. * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Jey <jey.nandakumar@gmail.com>
* image-has-acc-name: applicability should not use the acc tree * inapplicable examples for CSS * Apply suggestions from code review Co-authored-by: Carlos <carlosapaduarte@gmail.com> * Update image-non-empty-accessible-name-23a2a8.md * Update image-non-empty-accessible-name-23a2a8.md * Update image-non-empty-accessible-name-23a2a8.md * Update image-non-empty-accessible-name-23a2a8.md * Update image-non-empty-accessible-name-23a2a8.md Co-authored-by: Carlos <carlosapaduarte@gmail.com>
Co-authored-by: Jey <jey.nandakumar@gmail.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* Add WCAG non-interference as requirement * Fix indentation level Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Jey <jey.nandakumar@gmail.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* Modernise text contrast rule formatting - Moved notes to the background - Removed an unnecessary note - Updated to applicability to use conditional lists - Added dates to DOM spec definitions - Clarified the assumptions - Specified "flat tree" in the applicability * fix failing tests * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Jey <jey.nandakumar@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Jey <jey.nandakumar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating fork