Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "clip" from Scrollable element definition #1401

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

WilcoFiers
Copy link
Member

@WilcoFiers WilcoFiers commented Jul 23, 2020

overflow: clip does not cause scroll behaviour, it behaves very similar to overflow: hidden except that it clips in the padding box instead of the bounding box.

Closes #1388

Need for Final Call: 1 week

Copy link
Collaborator

@dd8 dd8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@WilcoFiers WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jul 23, 2020
@WilcoFiers WilcoFiers merged commit 7b9b109 into develop Jul 30, 2020
@WilcoFiers WilcoFiers deleted the clip-not-scrollable branch July 30, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overflow: clip is not scrollable
6 participants