Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"meta viewport does not prevent zoom" (b4f0c3): Added changes from TF review to rule. #1364

Merged
merged 4 commits into from
Jul 13, 2020
Merged

"meta viewport does not prevent zoom" (b4f0c3): Added changes from TF review to rule. #1364

merged 4 commits into from
Jul 13, 2020

Conversation

tbostic32
Copy link
Collaborator

Changes:

  1. Added 1.4.10 to accessibility mapping
  2. Added assumption about mechanism to resize text content.

Closes issue(s):

  • TF Review Changes

Need for Final Call:
This will require a 1 week Final Call

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Jym77 Jym77 changed the title Added changes from TF review to rule. "meta viewport does not prevent zoom" (b4f0c3): Added changes from TF review to rule. Jun 29, 2020
Jym77
Jym77 previously requested changes Jun 29, 2020
View reviewed changes
_rules/meta-viewport-b4f0c3.md Outdated
Comment on lines 12 to 17
inapplicable: further testing needed
wcag20:1.4.10: # Reflow (AA)
forConformance: true
failed: not satisfied
passed: further testing needed
inapplicable: further testing needed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's weird spacing on these lines which cause the tests to failed.

@WilcoFiers WilcoFiers dismissed Jym77’s stale review June 29, 2020 11:03

Spacing issue is fixed

@WilcoFiers WilcoFiers requested a review from Jym77 June 29, 2020 11:03
@kasperisager kasperisager removed their request for review June 30, 2020 08:28
@WilcoFiers
Copy link
Member

@tbostic32 Seeing as this is approved by three folks, I'm going to put it into final call for 1 week. Please leave the PR open until the end of that week.

@WilcoFiers WilcoFiers added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jun 30, 2020
@WilcoFiers WilcoFiers merged commit caf8951 into act-rules:develop Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

@Jym77 Jym77 Jym77 approved these changes

@adilsofficial adilsofficial Awaiting requested review from adilsofficial

@daniel-montalvo daniel-montalvo Awaiting requested review from daniel-montalvo

@jeeyyy jeeyyy Awaiting requested review from jeeyyy

@joao-vicente joao-vicente Awaiting requested review from joao-vicente

@ShadowBB ShadowBB Awaiting requested review from ShadowBB

Assignees

@tbostic32 tbostic32

Labels
ACT TF request Review Call 1 week Call for review for small changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tbostic32 @CLAassistant @WilcoFiers @carlosapaduarte @Jym77 @jeeyyy