rule-design: Update random ID generator #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the hex generator with an alphanumeric number generator.
carlosapaduarte
approved these changes
Jun 25, 2020
Jym77
previously requested changes
Jun 26, 2020
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Jym77
approved these changes
Jun 26, 2020
jeeyyy
approved these changes
Jun 26, 2020
|
I assume this is for future rules that is to be written & we do not intend on changing ids of existing rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the hex generator with an alphanumeric number generator.
Need for Final Call: None