easy way to switch from bundled libs to system #5
Conversation
We will try to detect system bullet. If it found - we will use it. If not found - use bundled bullet. Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
We will try to detect system enet. If it found - we will use it. If not found - use bundled enet. Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
We need to apply patch when we compiling STK with new version of bullet libraries. Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com> Reference: 49f5200
|
Hi, I had a good lock at this patch. As stated before, since we have modified bullet, enet, and especially irrlicht significantly, we do not want to use any system libs, since they might break things - sometimes subtle (e.g. physics might behave differently, that has happened in the past where a friction algorithm was changed), or severely (incorrect graphics, crash). I checked the changes to enet, and they were done during the GSoC, and I will clean this up (very likely revert enet to its original state), in which case at least enet could be replaced. Updating bullet to a newer version is a major undertaking, since (in the past) the physics behaviour can change drastically from one version to the next (which is why bullet recommends not to use a system library). If we should decide to update (unlikely at this stage tbh), and if we don't need a patched version of bullet anymore, I'll apply the cmake change to detect a system bullet. I also tried to apply the patches to bullet separately , but they are indeed all specific to bullet 2.81 only, so I can't use them. I'll close that pull request, but I opened #21 to unmodify irrlicht, and then apply the part of the patch so that enet can be exchanged. |
Changes from stk-code
- Adding the getTeamsInGame() and the setTeamsInGame method() Some modifications will be necessary.
… config names, disconnection time Please note that the results table schema may change later before merging #5. In this commit, the changes are: - added items TEXT, kart_color REAL, is_quit INTEGER - result stores kart's race time independently of whether it's a quit or not - config stores kart characteristics file name, items stores powerup file name, empty if the name is default. One may need to change NULL values in config and items to an empty string.
Command manager and latest updates
We don't like use bundled libraries in Fedora[0].
In this patch-set I want to improve easy switch.
General idea:
If system lib found - use it. If not found - use bundled.
In patch #3 I will apply patch if system bullet has version >= 2.81, because
there was changes and STK can't compile.
In the future I will update bundled bullet to 2.81, merge that patch and drop it.
[0]https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
I've sent this patches to devel lists, but for sure sending pull request here..
http://sourceforge.net/mailarchive/message.php?msg_id=31856369
http://sourceforge.net/mailarchive/message.php?msg_id=31856370
http://sourceforge.net/mailarchive/message.php?msg_id=31856371
http://sourceforge.net/mailarchive/message.php?msg_id=31856372