Addons installation crashs while unzipping

[supertuxkart-sourceforge-migration]

Author: hikerstk

If the zip files contains any folder, STK make a segfault.
I don't know if we must avoid to have folder or not, but, at least, we should handle this problem.

Here is the btacktrace:
#0 IFileSystem_copyFileToFile (dst=0x634e300, src=0x0) at addons/zip.cpp:33
#1 0x000000000041860c in extract_zip (from=,

to=) at addons/zip.cpp:82
#2 0x000000000041413b in AddonsManager::install (this=0x1010000,

addon=) at addons/addons_manager.cpp:185
#3 0x000000000053d1da in AddonsLoading::endInstall (

this=)
at states_screens/dialogs/addons_loading.cpp:217
#4 0x000000000053d639 in AddonsLoading::onUpdate (this=0x634a820,

delta=)
at states_screens/dialogs/addons_loading.cpp:170
#5 0x000000000046d80d in GUIEngine::render (

elapsed_time=) at guiengine/engine.cpp:971
#6 0x0000000000451457 in IrrDriver::update (this=0x8b4e20,

dt=) at graphics/irr_driver.cpp:928
#7 0x0000000000412284 in MainLoop::run (this=0x10d45a0) at main_loop.cpp:144
#8 0x0000000000410c28 in main (argc=,

argv=0x7fffffffe2e8) at main.cpp:823

For instance, try with BickBuckBunny.

Note: original summary was:
"Addons installation crashs with a .zip which contains folder", but it's an issue with the zip reader in irrlicht, not caused by them having folrder.

[supertuxkart-sourceforge-migration]

Author: hikerstk
hikerstk:
This appears to be a bug of the irrlicht zip file reader:
http://irrlicht.sourceforge.net/phpBB2/viewtopic.php?p=240943#240943
We might have to work around this if this can't be fixed in irrlicht in
time for our release. zip files could be patched so that they work
correctly with irrlicht (or just unzip and zip again on tuxfamily, I'd
guess that it's only Macs causing this problem).

[supertuxkart-sourceforge-migration]

Author: stephenjust
Stkaddons site automatically strips out any folders anyways, so this really isn't an issue.

[supertuxkart-sourceforge-migration]

Author: hikerstk
This issue was not actually related to folders (bad coincidence that it only happened with files containing folders). This is solved with the update to irrlicht 1.8 beta, and with the web page re-zipping files anyway (thanks).