Re-enable testing of unstable branches on GitHub Actions #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It turns out that Human Dynamics for unstable branches is actually still broken due to robotology/human-dynamics-estimation#162 , and the test in #302 were actually not testing the unstable branches. cc @Yeshasvitvs |
|
Obviously the iDynTree PR robotology/idyntree#600 had a regression, that should be fixed by robotology/idyntree#602 . |
|
All tests are now passing, @lrapetti if you could approve the PR it would be great, thanks! |
lrapetti
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test of unstable branches was added in #277 , but it was accidentally removed in #276 . This PR re-enables it, effectively enabling it for the first time on macOS and Wndows.