Do not quietly search for ASSIMP to decide if enable it or not #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DO_NOT_SILENTLY_SEARCH option to avoid the initial `find_package` QUIET call to decide the initial default value of the option to enable a dependency. Enable it for Assimp as a workaround for #599 .
lrapetti
approved these changes
Nov 26, 2019
lrapetti
approved these changes
Nov 26, 2019
This was referenced Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DO_NOT_SILENTLY_SEARCH option to avoid the initial
find_packageQUIET call to decide the initial default value of the option to enable a dependency.Enable it for Assimp as a workaround for #599 .
Assimp was added to GitHub Actons CI to validate that the solution is working.