Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic detection of available dependencies #602

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Fix automatic detection of available dependencies #602

merged 2 commits into from
Nov 26, 2019

Conversation

traversaro
Copy link
Member

PR #600 introduced the DO_NOT_SILENTLY_SEARCH for the idyntree_handle_dependency CMake function, but the option was not correctly passed to cmake_parse_arguments, so all the dependency were considered not enabled by default due to this.

This PR restores the original behaviour, before #600 .

@traversaro traversaro requested a review from lrapetti November 26, 2019 13:00
lrapetti
lrapetti approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@lrapetti lrapetti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the last commit LGTM. We can wait for the checks and merge

@traversaro traversaro mentioned this pull request Nov 26, 2019
Merged
@traversaro traversaro merged commit 0c0a451 into devel Nov 26, 2019
@traversaro traversaro deleted the fix-deps-auto branch November 26, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrapetti lrapetti lrapetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @lrapetti