Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compilation of Human Dynamics component in Continuous Integration #302

Merged
merged 2 commits into from
Nov 24, 2019

Conversation

traversaro
Copy link
Member

Thanks to robotology/wearables#65 , the issue with wearables compilation against the unstable branch of YARP was fixed.

@traversaro
Copy link
Member Author

Everything works fine on both Windows and Linux. : )
@lrapetti @Yeshasvitvs

@traversaro
Copy link
Member Author

And.. obviously everything compiles on Windows because there is an undocumented if that disables human-dynamics-estimation on Windows, see https://github.com/robotology/robotology-superbuild/pull/231/files#r349535694 . :D

@traversaro
Copy link
Member Author

And.. obviously everything compiles on Windows because there is an undocumented if that disables human-dynamics-estimation on Windows, see https://github.com/robotology/robotology-superbuild/pull/231/files#r349535694 . :D

I could not find any reason for which human-dynamics-estimation was not enabled on Windows in the original PR #231 . @kouroshD do you remember anything related to this?

@traversaro
Copy link
Member Author

Merge currently blocked by robotology/human-dynamics-estimation#160 .

@traversaro
Copy link
Member Author

Everything works fine now, thanks @lrapetti @diegoferigo !

@traversaro traversaro merged commit ad8cd96 into master Nov 24, 2019
@traversaro traversaro deleted the add-human-dyn-ci branch November 26, 2019 09:05
@kouroshD
Copy link
Contributor

And.. obviously everything compiles on Windows because there is an undocumented if that disables human-dynamics-estimation on Windows, see https://github.com/robotology/robotology-superbuild/pull/231/files#r349535694 . :D

I could not find any reason for which human-dynamics-estimation was not enabled on Windows in the original PR #231 . @kouroshD do you remember anything related to this?

I cannot recall now, but probably because there were some problem to run/build it on Windows when that PR was open. In any case, the right way is to have it in Windows as well.
In any case, we do not have visualization in Windows if I am not wrong, and normally we need to visualize, which needs to install ros in Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants