Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update taglib-2 from main #145

Merged
merged 14 commits into from
Apr 11, 2024
Merged

Update taglib-2 from main #145

merged 14 commits into from
Apr 11, 2024

Conversation

jacobvosmaer
Copy link
Collaborator

This merges recent fixes on main into taglib-2.

robinst and others added 14 commits April 6, 2024 14:42
See https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github

This will cause GitHub to collapse the changes in diffs by default.
The changes can still be viewed by expanding the diff if desired.
Should make it a bit easier to review PRs with changes to wrappers.
This is working towards deterministic `rake swig` (see
#136).
This reverts commit 59329af.

It turns out this is not great for GitHub PR review ergonomics after
all. We want to review _wrap.cxx changes even though they are
generated.
Fail CI if rake swig causes changes
@jacobvosmaer jacobvosmaer requested a review from robinst April 11, 2024 15:37
@jacobvosmaer
Copy link
Collaborator Author

@robinst I'm going to just merge this because you were OK with it in #143 (comment). Hope that is OK!

@jacobvosmaer jacobvosmaer merged commit c477cf8 into taglib-2 Apr 11, 2024
4 checks passed
@robinst
Copy link
Owner

robinst commented Apr 12, 2024

Yeah all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants