-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update taglib-2 from main #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github This will cause GitHub to collapse the changes in diffs by default. The changes can still be viewed by expanding the diff if desired. Should make it a bit easier to review PRs with changes to wrappers.
Fix build on main
Mark *_wrap.cxx as generated
This is working towards deterministic `rake swig` (see #136).
This reverts commit 59329af. It turns out this is not great for GitHub PR review ergonomics after all. We want to review _wrap.cxx changes even though they are generated.
Use vendored taglib for swig
Fail CI if rake swig causes changes
CI: add cache hit checks
@robinst I'm going to just merge this because you were OK with it in #143 (comment). Hope that is OK! |
Yeah all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges recent fixes on main into taglib-2.