Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail CI if rake swig causes changes #139

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fail CI if rake swig causes changes #139

merged 1 commit into from
Apr 9, 2024

Conversation

jacobvosmaer
Copy link
Collaborator

Closes #136

This adds a CI check that will cause a failed check if we accidentally commit a _wrap.cxx file that does not match the corresponding .i file.

@jacobvosmaer
Copy link
Collaborator Author

Here is an example failure, triggered by an intentionally wrong modified wrap file:

https://github.com/robinst/taglib-ruby/actions/runs/8602424269/job/23571960305?pr=139

Screenshot 2024-04-08 at 17 11 16

I will remove the "wrong" test commit now.

@jacobvosmaer jacobvosmaer requested a review from robinst April 8, 2024 15:15
@robinst robinst merged commit ee115f0 into main Apr 9, 2024
2 checks passed
@robinst
Copy link
Owner

robinst commented Apr 9, 2024

Nice, thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deterministic rake swig
2 participants