Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic rake swig #136

Closed
jacobvosmaer opened this issue Apr 6, 2024 · 3 comments · Fixed by #139
Closed

Deterministic rake swig #136

jacobvosmaer opened this issue Apr 6, 2024 · 3 comments · Fixed by #139
Assignees

Comments

@jacobvosmaer
Copy link
Collaborator

jacobvosmaer commented Apr 6, 2024

When I run rake swig on my development machine it is easy to get unwanted changes in the _wrap.cxx files. It would be nice if rake swig was deterministic. It makes life easier for contributors, and we could also check in CI that the generated files checked into Git are "correct".

Some things we would have to fix:

  • pin a version of taglib to run swig against. we could make a script that downloads a specific taglib tarball and unpacks it locally
  • run sed after swig to fix the @SWIG comments to use a fixed path (we can use swig -swiglib to find the string that needs to be replaced)
  • check the swig version from within rake swig
  • ... anything else ?
@robinst
Copy link
Owner

robinst commented Apr 6, 2024

Sounds good!

@jacobvosmaer jacobvosmaer self-assigned this Apr 6, 2024
@jacobvosmaer
Copy link
Collaborator Author

OK! I can work on this.

@robinst
Copy link
Owner

robinst commented Apr 6, 2024

Nice! Can you base it on main? We can later merge it into the taglib-2 branch (or rebase).

jacobvosmaer added a commit that referenced this issue Apr 6, 2024
This is working towards deterministic `rake swig` (see
#136).
jacobvosmaer added a commit that referenced this issue Apr 6, 2024
This is working towards deterministic `rake swig` (see
#136).
jacobvosmaer added a commit that referenced this issue Apr 7, 2024
This is working towards deterministic `rake swig` (see
#136).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants