Use vendored taglib for swig #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobvosmaer
commented
Apr 6, 2024
jacobvosmaer
commented
Apr 6, 2024
jacobvosmaer
commented
Apr 6, 2024
jacobvosmaer
commented
Apr 6, 2024
28f1f9f to
5d092fb
Compare
robinst
approved these changes
Apr 7, 2024
This is working towards deterministic `rake swig` (see #136).
dc190f3 to
f950e87
Compare
jacobvosmaer
commented
Apr 7, 2024
f950e87 to
0e6ff61
Compare
robinst
approved these changes
Apr 7, 2024
|
@robinst is there anything else we need to do in this PR before we merge? |
|
No, you can go ahead and merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working towards deterministic
rake swig(see #136).rake swiguse the taglib installed byrake vendorrake vendor(the checked-in wrapper files were already based on 1.11.1)@SWIGcomments so they don't depend on where the developer installed swig